From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans-Christian Egtvedt Subject: Re: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines Date: Mon, 12 Aug 2013 09:10:42 +0200 Message-ID: <20130812071042.GA30670@samfundet.no> References: <20130810082333.GA27640@samfundet.no> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Viresh Kumar Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Around Mon 12 Aug 2013 11:37:45 +0530 or thereabout, Viresh Kumar wrote: > On 10 August 2013 13:53, Hans-Christian Egtvedt wrote: >> Around Sat 10 Aug 2013 12:14:07 +0530 or thereabout, Viresh Kumar wrote: >>> Most of the CPUFreq drivers do similar things in .exit() and .verify() routines >>> and .attr. So its better if we have generic routines for them which can be used >>> by cpufreq drivers then. >>> >>> This patch uses these generic routines for this driver. >> >> Nice, thanks for cleaning up (-: >> >>> Cc: Hans-Christian Egtvedt >>> Signed-off-by: Viresh Kumar >> >> Acked-by: Hans-Christian Egtvedt > > Thanks for your Ack but I have to NACK it :) > > My patch was wrong.. It was based on the assumption that everybody who > had implemented a .target() also implements a frequency table and exposes > it.. And the generic routines I have exposed depend on that frequency table. > And this cpufreq driver doesn't expose that freq table... Right, my bad, I just looked at the code flow and saw that the generic path did pretty much the same as the AVR32 implementation. Didn't consider the table part as missing. > And so this patch is dropped :( > Ok, AVR32 driver should expose a frequency table then, which is quite simple. -- mvh Hans-Christian Egtvedt