From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: pbonzini@redhat.com, Anthony Liguori <aliguori@us.ibm.com>,
Laszlo Ersek <lersek@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-1.6 1/2] memory: export target page size
Date: Mon, 12 Aug 2013 12:25:00 +0300 [thread overview]
Message-ID: <20130812092500.GA30732@redhat.com> (raw)
In-Reply-To: <CAFEAcA_qNB4MJs=QpVfJ595qenqW_0PddikdSbaCZQSNhH_54g@mail.gmail.com>
On Mon, Aug 12, 2013 at 10:17:46AM +0100, Peter Maydell wrote:
> On 12 August 2013 09:49, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Add symbol to make it possible to use target page size
> > in target-independent code.
>
> Given that TARGET_PAGE_SIZE is "smallest page size the
> TCG implementation currently supports for this core"
> (ie it is a TCG internal implementation detail as much
> as a property of the target CPU and it may well not
> match the actual page size being used by the guest)
> I would be very suspicious of any target-independent
> code that uses it.
>
> -- PMM
Look at the next patch and the comment justifying its use please.
Point is migration works in units of TARGET_PAGE_SIZE
and expects all RAM blocks to be a multiple of that.
What if we rename this to qemu_migration_page_size ?
Will this address your comment?
--
MST
next prev parent reply other threads:[~2013-08-12 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 8:49 [Qemu-devel] [PATCH for-1.6 0/2] future proof rom loading for cross versiom migration Michael S. Tsirkin
2013-08-12 8:49 ` [Qemu-devel] [PATCH for-1.6 1/2] memory: export target page size Michael S. Tsirkin
2013-08-12 9:17 ` Peter Maydell
2013-08-12 9:25 ` Michael S. Tsirkin [this message]
2013-08-12 8:49 ` [Qemu-devel] [PATCH for-1.6 2/2] loader: put FW CFG ROM files into RAM Michael S. Tsirkin
2013-08-12 9:32 ` Peter Maydell
2013-08-12 10:07 ` Michael S. Tsirkin
2013-08-12 13:57 ` [Qemu-devel] [PATCH for-1.6 0/2] future proof rom loading for cross versiom migration Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812092500.GA30732@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.