From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] USB: OHCI: make ohci-nxp a separate driver
Date: Mon, 12 Aug 2013 13:22:49 -0700 [thread overview]
Message-ID: <20130812202249.GA26423@kroah.com> (raw)
In-Reply-To: <1376120655-31149-1-git-send-email-manjunath.goudar@linaro.org>
On Sat, Aug 10, 2013 at 01:14:15PM +0530, Manjunath Goudar wrote:
> Separate the OHCI NXP host controller driver from ohci-hcd
> host code so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM.
>
> Many place function name and struct name started with usb,
> current scenario replaced usb with ohci for proper naming.
>
> Signed-off-by: Manjunath Goudar <manjunath.goudar@linaro.org>
> Signed-off-by: Deepak Saxena <dsaxena@linaro.org>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg KH <greg@kroah.com>
> Cc: linux-usb at vger.kernel.org
>
> V2:
> - Directive check NXP_PLATFORM_DRIVER block has been removed.
> ---
> drivers/usb/host/Kconfig | 8 +++
> drivers/usb/host/Makefile | 1 +
> drivers/usb/host/ohci-hcd.c | 18 -------
> drivers/usb/host/ohci-nxp.c | 124 +++++++++++++++++--------------------------
> 4 files changed, 58 insertions(+), 93 deletions(-)
Also failed to apply:
checking file drivers/usb/host/Kconfig
Hunk #1 FAILED at 398.
1 out of 1 hunk FAILED
checking file drivers/usb/host/Makefile
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED
checking file drivers/usb/host/ohci-hcd.c
Hunk #1 succeeded at 1212 with fuzz 1 (offset 18 lines).
Hunk #2 succeeded at 1349 with fuzz 1 (offset 53 lines).
Hunk #3 FAILED at 1309.
Hunk #4 FAILED at 1357.
2 out of 4 hunks FAILED
checking file drivers/usb/host/ohci-nxp.c
{sigh}
That's why I required a senior Linaro developer to approve these
patches. You just wasted a bunch of my time, and it was obvious that no
one else actually tried these patches out, as they can't even be
applied!
Deepak, come on, you know better :(
greg k-h
prev parent reply other threads:[~2013-08-12 20:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 9:50 [PATCH] USB: OHCI: make ohci-nxp a separate driver Manjunath Goudar
2013-07-01 20:50 ` Alan Stern
2013-07-02 11:50 ` [PATCH V2] " Manjunath Goudar
2013-07-02 15:26 ` Alan Stern
2013-07-22 10:04 ` Manjunath Goudar
2013-08-10 7:44 ` Manjunath Goudar
2013-08-12 20:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812202249.GA26423@kroah.com \
--to=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.