From: Greg KH <gregkh@linuxfoundation.org>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: Linux-Devel <devel@driverdev.osuosl.org>,
Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Review [2/2] Staging: BCM: Removed more whitespace/Errors
Date: Mon, 12 Aug 2013 15:13:21 -0700 [thread overview]
Message-ID: <20130812221321.GC18287@kroah.com> (raw)
In-Reply-To: <5203D6E4.9080201@gmail.com>
On Thu, Aug 08, 2013 at 06:35:32PM +0100, Paul McQuade wrote:
> From 9f6231ce16996e35545e20ce1d91abc058f2a6fb Mon Sep 17 00:00:00 2001
> From: Paul McQuade <paulmcquad@gmail.com>
> Date: Thu, 8 Aug 2013 17:49:22 +0100
> Subject: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors
Why is this duplicated here?
Just use 'git send-email' to send patches out, that way this isn't a
problem, and also:
> drivers/staging/bcm/InterfaceMacros.h | 6 +-
> drivers/staging/bcm/InterfaceMisc.h | 14 +--
> drivers/staging/bcm/InterfaceRx.c | 166
> ++++++++++++++-------------------
Your patch is line-wrapped, making it impossible to apply :(
The whitespace is also all broken.
Take a look at the kernel file, Documentation/email_clients.txt for how
to fix this up properly.
thanks,
greg k-h
prev parent reply other threads:[~2013-08-12 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 17:35 Review [2/2] Staging: BCM: Removed more whitespace/Errors Paul McQuade
2013-08-08 18:50 ` Joe Perches
2013-08-08 20:54 ` Dan Carpenter
2013-08-08 21:02 ` Joe Perches
2013-08-12 22:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812221321.GC18287@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmcquad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.