All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: vt6656: rxtx.h always pack BEACON_BUFFER/TX_BUFFER
Date: Mon, 12 Aug 2013 16:09:36 -0700	[thread overview]
Message-ID: <20130812230936.GA31302@kroah.com> (raw)
In-Reply-To: <1376348835.12399.15.camel@canaries32-MCP7A>

On Tue, Aug 13, 2013 at 12:07:15AM +0100, Malcolm Priestley wrote:
> On Mon, 2013-08-12 at 14:59 -0700, Greg KH wrote:
> > On Mon, Aug 05, 2013 at 09:04:54PM +0100, Malcolm Priestley wrote:
> > > All structure members of BEACON_BUFFER/TX_BUFFER should be packed.
> > 
> > Why?
> 
> Only the first 4 members of these structures are live.
> 
> The forth member is referenced at run-time by packed structures.
> typedef struct tagSTxBufHead
> typedef struct tagSTxShortBufHead
> in desc.h
> 
> If these structures are not packed the alignment of these members
> will be wrong.

Then say all of this in the patch please :)

> > 
> > What happens if they are not?
> The driver does not work.

How is it working today without this change?

thanks,

greg k-h

  reply	other threads:[~2013-08-12 23:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 20:04 [PATCH 1/3] staging: vt6656: rxtx.h always pack BEACON_BUFFER/TX_BUFFER Malcolm Priestley
2013-08-12 21:59 ` Greg KH
2013-08-12 23:07   ` Malcolm Priestley
2013-08-12 23:09     ` Greg KH [this message]
2013-08-12 23:35       ` Malcolm Priestley
2013-08-13  0:26         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130812230936.GA31302@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.