From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V92E4-000735-RE for qemu-devel@nongnu.org; Mon, 12 Aug 2013 20:12:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V92E0-0001bT-3b for qemu-devel@nongnu.org; Mon, 12 Aug 2013 20:12:40 -0400 Sender: fluxion Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <20130812224300.26907.97344@loki> References: <1371073298-14519-1-git-send-email-mdroth@linux.vnet.ibm.com> <1371073298-14519-10-git-send-email-mdroth@linux.vnet.ibm.com> <1372882200.2883.208.camel@ul30vt.home> <1372888316.2883.219.camel@ul30vt.home> <20130812224300.26907.97344@loki> Message-ID: <20130813001231.26884.54054@loki> Date: Mon, 12 Aug 2013 19:12:31 -0500 Subject: Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org Quoting Michael Roth (2013-08-12 17:43:00) > Quoting Alex Williamson (2013-07-03 16:51:56) > > On Wed, 2013-07-03 at 15:16 -0500, Michael Roth wrote: > > > On Wed, Jul 3, 2013 at 3:10 PM, Alex Williamson > > > wrote: > > > > On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: > > > >> From: Andreas F=C3=A4rber > > > >> > > > >> The implementation of the ATA FLUSH command invokes a flush at the= block > > > >> layer, which may on raw files on POSIX entail a synchronous fdatas= ync(). > > > >> This may in some cases take so long that the SLES 11 SP1 guest dri= ver > > > >> reports I/O errors and filesystems get corrupted or remounted read= -only. > > > >> > > > >> Avoid this by setting BUSY_STAT, so that the guest is made aware w= e are > > > >> in the middle of an operation and no ATA commands are attempted to= be > > > >> processed concurrently. > > > >> > > > >> Addresses BNC#637297. > > > >> > > > >> Suggested-by: Gonglei (Arei) > > > >> Signed-off-by: Andreas F=C3=A4rber > > > >> Signed-off-by: Kevin Wolf > > > >> Signed-off-by: Stefan Hajnoczi > > > >> (cherry picked from commit f68ec8379e88502b4841a110c070e9b118d3151= c) > > > >> > > > >> Signed-off-by: Michael Roth > > > >> --- > > > >> hw/ide/core.c | 1 + > > > >> 1 file changed, 1 insertion(+) > > > >> > > > >> diff --git a/hw/ide/core.c b/hw/ide/core.c > > > >> index c7a8041..9926d92 100644 > > > >> --- a/hw/ide/core.c > > > >> +++ b/hw/ide/core.c > > > >> @@ -814,6 +814,7 @@ void ide_flush_cache(IDEState *s) > > > >> return; > > > >> } > > > >> > > > >> + s->status |=3D BUSY_STAT; > > > >> bdrv_acct_start(s->bs, &s->acct, 0, BDRV_ACCT_FLUSH); > > > >> bdrv_aio_flush(s->bs, ide_flush_cb, s); > > > >> } > > > > > > > > This caused a regression for me from 1.5.0->1.5.1. Windows 7 x64 no > > > > longer boots on q35 IDE with this change. Thanks, > > > = > > > Are you seeing the issue for upstream builds as well? > > = > > Yes, I bisected this on upstream. If i revert just this from 1.5.1, I > > can boot again. Upstream requires reverting this and a workaround for > > 9afce429. Thanks, > = > Does the problem still exist upstream? I'd rather not revert without a > fix for the issue in 9afce429 since that might cause a regression for 1.5= .1 > users now. Ok, looks like we have a fix for this that was already sent to stable: a62eaa26c1d6d48fbdc3ac1d32bd1314f5fdc8c9 Could've sworn I searched master for a reference to f68ec837... Will pull it in for 1.5.3 > = > Sucks either way but I think it's safer to have Win7 not boot on q35 than > re-introduce potential image corruption. > = > > = > > Alex