From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Dmitry Kravkov <dmitry@broadcom.com>, ariele@broadcom.com
Cc: davem@davemloft.net, netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH net v5 0/5] bnx2x: fixes
Date: Tue, 13 Aug 2013 08:30:43 -0400 [thread overview]
Message-ID: <20130813123043.GA30192@d2.synalogic.ca> (raw)
In-Reply-To: <1376349903-3461-1-git-send-email-dmitry@broadcom.com>
On 2013/08/13 02:24, Dmitry Kravkov wrote:
> Hello Dave
>
> Please consider applying the series of bnx2x fixes to net:
> * statistics may cause FW assert
> * missing fairness configuration in DCB flow
> * memory leak in sriov related part
> * Illegal PTE access
> * Pagefault crash in shutdown flow with cnic
> v1->v2
> * fixed sparse error pointed by Joe Perches
> * added missing signed-off from Sergei Shtylyov
> v2->v3
> * added missing signed-off from Sergei Shtylyov
> * fixed formatting from Sergei Shtylyov
> v3->v4
> * patch 1/6: fixed declaration order
> * patch 2/6 replaced with: protect flows using set_bit constraints
> v4->v5
> * patch 2/6: replace proprietary locking with semaphore
> * droped 1/6: since adds redundant code from Benjamin Poirier
I'm confused. Wasn't "[PATCH net v4 1/6] bnx2x: properly initialize
statistic counters" supposed to fix a race condition? According to
earlier communication with Ariel:
In this issue a race condition at driver startup causes a second
statistics query to be sent before the first one completes,
resulting in a firmware assert and a stuck chip. A patch was
sent upstream fixing this:
http://patchwork.ozlabs.org/patch/264810/
next prev parent reply other threads:[~2013-08-13 12:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 23:24 [PATCH net v5 0/5] bnx2x: fixes Dmitry Kravkov
2013-08-12 23:24 ` [PATCH net v5 1/5] bnx2x: protect different statistics flows Dmitry Kravkov
2013-08-13 0:12 ` Stephen Hemminger
2013-08-13 4:24 ` David Miller
2013-08-13 17:57 ` Stephen Hemminger
2013-08-13 17:54 ` Neal Cardwell
2013-08-12 23:25 ` [PATCH net v5 2/5] bnx2x: update fairness parameters following DCB negotiation Dmitry Kravkov
2013-08-12 23:25 ` [PATCH net v5 3/5] bnx2x: fix memory leak in VF Dmitry Kravkov
2013-08-12 23:25 ` [PATCH net v5 4/5] bnx2x: fix PTE write access error Dmitry Kravkov
2013-08-12 23:25 ` [PATCH net v5 5/5] bnx2x: prevent crash in shutdown flow with CNIC Dmitry Kravkov
2013-08-13 12:30 ` Benjamin Poirier [this message]
2013-08-13 12:38 ` [PATCH net v5 0/5] bnx2x: fixes Ariel Elior
2013-08-13 14:07 ` Benjamin Poirier
2013-08-13 14:16 ` Dmitry Kravkov
2013-08-13 17:44 ` Benjamin Poirier
2013-08-13 23:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813123043.GA30192@d2.synalogic.ca \
--to=benjamin.poirier@gmail.com \
--cc=ariele@broadcom.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.