From: Josh Cartwright <joshc@codeaurora.org>
To: Sujit Reddy Thumma <sthumma@codeaurora.org>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>,
Santosh Y <santoshsy@gmail.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] scsi: ufs: Allow vendor specific initialization
Date: Tue, 13 Aug 2013 08:53:52 -0500 [thread overview]
Message-ID: <20130813135352.GE31772@joshc.qualcomm.com> (raw)
In-Reply-To: <1376391620-13840-2-git-send-email-sthumma@codeaurora.org>
On Tue, Aug 13, 2013 at 04:30:18PM +0530, Sujit Reddy Thumma wrote:
[..]
> diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
> index a823cf4..829f7a4 100644
> --- a/drivers/scsi/ufs/ufshcd-pci.c
> +++ b/drivers/scsi/ufs/ufshcd-pci.c
> @@ -191,7 +191,13 @@ ufshcd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> return err;
> }
>
> - err = ufshcd_init(&pdev->dev, &hba, mmio_base, pdev->irq);
> + err = ufshcd_alloc_host(&pdev->dev, &hba);
> + if (err) {
> + dev_err(&pdev->dev, "Allocation failed\n");
> + goto out_iounmap
You seem to be missing a semicolon here.
Also, which tree were these patches generated against? They fail to
apply at least on the last few 3.11-rc's.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-08-13 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 11:00 [PATCH 0/3] scsi: ufs: Add support for clock and regulator initializaiton Sujit Reddy Thumma
2013-08-13 11:00 ` [PATCH 1/3] scsi: ufs: Allow vendor specific initialization Sujit Reddy Thumma
2013-08-13 13:53 ` Josh Cartwright [this message]
2013-08-13 14:12 ` Sujit Reddy Thumma
2013-08-13 11:00 ` [PATCH 2/3] scsi: ufs: Add regulator enable support Sujit Reddy Thumma
2013-08-13 11:00 ` [PATCH 3/3] scsi: ufs: Add clock initialization support Sujit Reddy Thumma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813135352.GE31772@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=JBottomley@parallels.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshsy@gmail.com \
--cc=sthumma@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.