All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: link libxtables against libnetfilter_conntrack
Date: Tue, 13 Aug 2013 15:59:32 +0200	[thread overview]
Message-ID: <20130813135932.GJ29345@breakpoint.cc> (raw)
In-Reply-To: <1376399723-9967-1-git-send-email-gustavo@zacarias.com.ar>

Gustavo Zacarias <gustavo@zacarias.com.ar> wrote:
> When libnetfilter_conntrack is available libxtables needs to link
> against it otherwise we get build failures.

Only with --enable-static, right?
Can you make it conditional on ENABLE_STATIC, like this?

diff --git a/libxtables/Makefile.am b/libxtables/Makefile.am
index c5795fe..3de2e15 100644
--- a/libxtables/Makefile.am
+++ b/libxtables/Makefile.am
@@ -11,6 +11,9 @@ if ENABLE_STATIC
 # With --enable-static, shipped extensions are linked into the main executable,
 # so we need all the LIBADDs here too
 libxtables_la_LIBADD += -lm
+if HAVE_LIBNETFILTER_CONNTRACK
+libxtables_la_LIBADD += @libnetfilter_conntrack_LIBS@
+endif
 endif
 if ENABLE_SHARED
 libxtables_la_CFLAGS  = ${AM_CFLAGS}

  reply	other threads:[~2013-08-13 13:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13 13:15 [PATCH] iptables: link libxtables against libnetfilter_conntrack Gustavo Zacarias
2013-08-13 13:59 ` Florian Westphal [this message]
2013-08-13 14:19   ` Gustavo Zacarias
2013-08-13 15:32     ` Florian Westphal
2013-08-13 16:36       ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813135932.GJ29345@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=gustavo@zacarias.com.ar \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.