From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH lnf-queue] build: avoid sym namespace pollution
Date: Tue, 13 Aug 2013 18:15:51 +0200 [thread overview]
Message-ID: <20130813161551.GA3901@localhost> (raw)
In-Reply-To: <1376383730-11731-1-git-send-email-fw@strlen.de>
On Tue, Aug 13, 2013 at 10:48:50AM +0200, Florian Westphal wrote:
> as of f40eabb01 (add pkt_buff and protocol helper functions)
> lnetfilter_queue exports a function named 'checksum'. This is a bit
> too generic and causes crash with applications that worked fine before.
I see, that was not the intention as they are supposed to be internal
(as you can see in src/internal.h), however, it seems that the
visibility changes were incomplete, sorry.
> This patch makes the functions checksum, checksum_tcpudp_ipv4 and
> checksum_tcpudp_ipv6 local by building with fvis-hidden and adding
> EXPORTs for the legacy api calls and the ones that seem to have missing
> EXPORT tags (mainly pktbuf api).
I have applied this, thanks Florian.
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Alternative would be to rename "checksum" to something
I have just renamed those, even if they are internal I think it's a
good cleanup.
prev parent reply other threads:[~2013-08-13 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 8:48 [PATCH lnf-queue] build: avoid sym namespace pollution Florian Westphal
2013-08-13 16:15 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813161551.GA3901@localhost \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.