From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] Add Nanobone board support
Date: Tue, 13 Aug 2013 12:21:38 -0400 [thread overview]
Message-ID: <20130813162138.GH18706@bill-the-cat> (raw)
In-Reply-To: <520A5A55.9030305@newflow.co.uk>
On Tue, Aug 13, 2013 at 05:09:57PM +0100, Mark Jackson wrote:
> +++ b/board/newflow/nanobone/board.c
[snip]
> +#if defined(CONFIG_SPL_BUILD) || (CONFIG_NOR_BOOT)
> +//static struct uart_sys *uart_base = (struct uart_sys *)DEFAULT_UART_BASE;
> +#endif
Here and elsewhere, remove commented out code.
> +++ b/include/configs/nanobone.h
[snip]
> +#define CONFIG_DMA_COHERENT
> +#define CONFIG_DMA_COHERENT_SIZE (1 << 20)
[snip]
> +#define CONFIG_STACKSIZE (128 * 1024)
Unused
[snip]
> +#define CONFIG_CMD_FAT
> +#define CONFIG_CMD_EXT2
> +#define CONFIG_CMD_EXT4
But no CONFIG_CMD_FS_GENERIC ?
> + /* Physical Memory Map */
> +#define CONFIG_NR_DRAM_BANKS 1 /* 1 bank of DRAM */
> +#define PHYS_DRAM_1 0x80000000 /* DRAM Bank #1 */
> +#define CONFIG_MAX_RAM_BANK_SIZE (1024 << 20) /* 1GB */
Please just use 0x80000000 directly in later defines, or
CONFIG_SYS_SDRAM_BASE in code.
[snip]
> +#define CONFIG_SPL_NET_VCI_STRING "AM335x U-Boot SPL"
I would strongly encourage "nanobone" somewhere in this string, so that
you don't feed the binary for an am335x_evm.h-based board to this board.
Or drop if you aren't really supporting SPL via USB or ethernet.
> +/* Unsupported features */
> +#undef CONFIG_USE_IRQ
[snip]
> +#define CONFIG_BOOTP_DEFAULT
Unused.
And I realize everything but the VCI string and lack of
CONFIG_CMD_FS_GENERIC is inherited from am335x_evm.h, I'm working on a
series to fix that now.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130813/8a4051b4/attachment.pgp>
prev parent reply other threads:[~2013-08-13 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 16:09 [U-Boot] [PATCH v3] Add Nanobone board support Mark Jackson
2013-08-13 16:21 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813162138.GH18706@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.