All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Phil Blundell <pb@pbcl.net>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: Enabling x264 support in gstreamer
Date: Tue, 13 Aug 2013 22:09:41 +0200	[thread overview]
Message-ID: <20130813200941.GO17945@jama> (raw)
In-Reply-To: <1376422569.5025.20.camel@x121e.pbcl.net>

[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]

On Tue, Aug 13, 2013 at 08:36:09PM +0100, Phil Blundell wrote:
> On Tue, 2013-08-13 at 13:26 -0600, Gary Thomas wrote:
> > On 2013-08-13 11:36, Martin Jansa wrote:
> > > On Tue, Aug 13, 2013 at 11:29:10AM -0600, Gary Thomas wrote:
> > >> I see that some of the gstreamer recipes have changed so that x264
> > >> is now a PACKAGECONFIG option.  However, I don't see anything that
> > >> enables this option anywhere.
> > >>
> > >> How do I get x264 support back - it was working with Poky/Yocto
> > >> just a few weeks back...
> > >>
> > >> Note: I have imported meta-oe/recipes-multimedia/x264 from meta-openembedded
> > >> into my layers for this [library] package.
> > >
> > > Add x264 to PACKAGECONFIG in your .bbappend or distro config as
> > > PACKAGECONFIG_append_pn-gst-foo = " x264"
> > 
> > Thanks, although this seems very cumbersome to me.  Is this the only
> > (or at least expected) way for this to work?
> 
> Well, if it's in a .bbappend (rather than distro.conf) then you don't
> need the _append_pn-gst-foo bit, you can just write
> 
> PACKAGECONFIG += "x264"
> 
> which is probably a bit neater and more intuitive.  But if you don't
> already have a .bbappend for that recipe then you might not want to add
> one just for that, it's just a matter of taste which you prefer.
> 
> Other than that, yes, this is basically how PACKAGECONFIG is intended to
> be used.  Some recipes set a default PACKAGECONFIG based on
> DISTRO_FEATURES, but in the general case it's just a variable that you
> need to set appropriately.
> 
> The thing that's a bit unsatisfactory about this approach is that we
> don't have any equivalent to DISTRO_FEATURES_BACKFILL for recipe-local
> PACKAGECONFIG options, which means that introducing new switches for
> things that were previously default-on tends to cause unexpected
> breakage of the sort that you've observed.  It would be good to figure
> out a better way of dealing with that.

Well on this case x264 cannot be enabled in gst-* recipe in oe-core,
because x264 is in different layer.

The old behavior Gary was depending on wasn't deterministic as x264 was
enabled only when he built x264 before gst-*.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  parent reply	other threads:[~2013-08-13 20:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13 17:29 Enabling x264 support in gstreamer Gary Thomas
2013-08-13 17:36 ` Martin Jansa
2013-08-13 19:26   ` Gary Thomas
2013-08-13 19:36     ` Phil Blundell
2013-08-13 19:42       ` Paul Eggleton
2013-08-13 20:09       ` Martin Jansa [this message]
2013-08-13 17:37 ` Mark Hatle
2013-08-13 19:45   ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813200941.GO17945@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pb@pbcl.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.