From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Date: Wed, 14 Aug 2013 10:09:12 +0800 Message-ID: <20130814020911.GA31651@MrMyself> References: <1376308870-14232-1-git-send-email-b42378@freescale.com> <1376308870-14232-2-git-send-email-b42378@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from va3outboundpool.messaging.microsoft.com (va3ehsobe006.messaging.microsoft.com [216.32.180.16]) by alsa0.perex.cz (Postfix) with ESMTP id 44E9B261A0B for ; Wed, 14 Aug 2013 04:23:07 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Fabio Estevam Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lars@metafoo.de, timur@tabi.org, rob.herring@calxeda.com, broonie@kernel.org, p.zabel@pengutronix.de, Shawn Guo , linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org Hi Fabio, Thank you for the comments. On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote: > On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote: > > +Required properties: > > + > > + - compatible : Compatible list, contains "fsl,-spdif". Using general > > Can't we just use "fsl,fsl-spdif" instead? > > > + "fsl,fsl-spdif" will get the default SoC type -- imx6q-spdif. > > + > > I think this is not the usual approach we do with dt. > > > +static const struct of_device_id fsl_spdif_dt_ids[] = { > > + { .compatible = "fsl,fsl-spdif", }, > > Isn't only the first entry enough here? I just saw Mark's words as well. So I don't need to change this part right? But I'd like to add imx35 on it. > This MODULE_ALIAS name does not match the name you provided earlier: > > .name = "fsl-spdif-dai" > I'll fix it in v5. Best regards, Nicolin Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va3outboundpool.messaging.microsoft.com (va3ehsobe002.messaging.microsoft.com [216.32.180.12]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 54E9F2C010A for ; Wed, 14 Aug 2013 12:23:11 +1000 (EST) Date: Wed, 14 Aug 2013 10:09:12 +0800 From: Nicolin Chen To: Fabio Estevam Subject: Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Message-ID: <20130814020911.GA31651@MrMyself> References: <1376308870-14232-1-git-send-email-b42378@freescale.com> <1376308870-14232-2-git-send-email-b42378@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lars@metafoo.de, timur@tabi.org, rob.herring@calxeda.com, broonie@kernel.org, p.zabel@pengutronix.de, Shawn Guo , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Fabio, Thank you for the comments. On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote: > On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote: > > +Required properties: > > + > > + - compatible : Compatible list, contains "fsl,-spdif". Using general > > Can't we just use "fsl,fsl-spdif" instead? > > > + "fsl,fsl-spdif" will get the default SoC type -- imx6q-spdif. > > + > > I think this is not the usual approach we do with dt. > > > +static const struct of_device_id fsl_spdif_dt_ids[] = { > > + { .compatible = "fsl,fsl-spdif", }, > > Isn't only the first entry enough here? I just saw Mark's words as well. So I don't need to change this part right? But I'd like to add imx35 on it. > This MODULE_ALIAS name does not match the name you provided earlier: > > .name = "fsl-spdif-dai" > I'll fix it in v5. Best regards, Nicolin Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [216.32.180.12] ([216.32.180.12]:37544 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1758878Ab3HNCY5 (ORCPT ); Tue, 13 Aug 2013 22:24:57 -0400 Date: Wed, 14 Aug 2013 10:09:12 +0800 From: Nicolin Chen Subject: Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Message-ID: <20130814020911.GA31651@MrMyself> References: <1376308870-14232-1-git-send-email-b42378@freescale.com> <1376308870-14232-2-git-send-email-b42378@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org To: Fabio Estevam Cc: broonie@kernel.org, lars@metafoo.de, p.zabel@pengutronix.de, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, timur@tabi.org, rob.herring@calxeda.com, Shawn Guo List-ID: Hi Fabio, Thank you for the comments. On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote: > On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote: > > +Required properties: > > + > > + - compatible : Compatible list, contains "fsl,-spdif". Using general > > Can't we just use "fsl,fsl-spdif" instead? > > > + "fsl,fsl-spdif" will get the default SoC type -- imx6q-spdif. > > + > > I think this is not the usual approach we do with dt. > > > +static const struct of_device_id fsl_spdif_dt_ids[] = { > > + { .compatible = "fsl,fsl-spdif", }, > > Isn't only the first entry enough here? I just saw Mark's words as well. So I don't need to change this part right? But I'd like to add imx35 on it. > This MODULE_ALIAS name does not match the name you provided earlier: > > .name = "fsl-spdif-dai" > I'll fix it in v5. Best regards, Nicolin Chen