From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Date: Wed, 14 Aug 2013 13:30:17 +0800 Message-ID: <20130814053016.GF31651@MrMyself> References: <1376308870-14232-1-git-send-email-b42378@freescale.com> <1376308870-14232-2-git-send-email-b42378@freescale.com> <20130814032658.GA16915@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from db9outboundpool.messaging.microsoft.com (mail-db9lp0252.outbound.messaging.microsoft.com [213.199.154.252]) by alsa0.perex.cz (Postfix) with ESMTP id D6A472619D5 for ; Wed, 14 Aug 2013 07:44:03 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20130814032658.GA16915@S2101-09.ap.freescale.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Shawn Guo Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lars@metafoo.de, linuxppc-dev@lists.ozlabs.org, timur@tabi.org, rob.herring@calxeda.com, broonie@kernel.org, p.zabel@pengutronix.de, Fabio Estevam List-Id: alsa-devel@alsa-project.org Hi Shwan, On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote: > I do not think we need this general compatible string. Device tree > compatible should be specific. So I should just use 'fsl,-spdif" and list all -spdif in compatible list? I added 'fsl,fsl-spdif' just for those not-in-list chips, Vybrid for example. So you think I should add all the possible chips to the list? But what if some chip I don't know right now that also uses this spdif controller? Add them to the list later? Thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from db9outboundpool.messaging.microsoft.com (mail-db9lp0250.outbound.messaging.microsoft.com [213.199.154.250]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id BAFFA2C0133 for ; Wed, 14 Aug 2013 15:44:10 +1000 (EST) Date: Wed, 14 Aug 2013 13:30:17 +0800 From: Nicolin Chen To: Shawn Guo Subject: Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Message-ID: <20130814053016.GF31651@MrMyself> References: <1376308870-14232-1-git-send-email-b42378@freescale.com> <1376308870-14232-2-git-send-email-b42378@freescale.com> <20130814032658.GA16915@S2101-09.ap.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20130814032658.GA16915@S2101-09.ap.freescale.net> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lars@metafoo.de, linuxppc-dev@lists.ozlabs.org, timur@tabi.org, rob.herring@calxeda.com, broonie@kernel.org, p.zabel@pengutronix.de, Fabio Estevam List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Shwan, On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote: > I do not think we need this general compatible string. Device tree > compatible should be specific. So I should just use 'fsl,-spdif" and list all -spdif in compatible list? I added 'fsl,fsl-spdif' just for those not-in-list chips, Vybrid for example. So you think I should add all the possible chips to the list? But what if some chip I don't know right now that also uses this spdif controller? Add them to the list later? Thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [213.199.154.253] ([213.199.154.253]:20101 "EHLO db9outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751736Ab3HNFpT (ORCPT ); Wed, 14 Aug 2013 01:45:19 -0400 Date: Wed, 14 Aug 2013 13:30:17 +0800 From: Nicolin Chen Subject: Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Message-ID: <20130814053016.GF31651@MrMyself> References: <1376308870-14232-1-git-send-email-b42378@freescale.com> <1376308870-14232-2-git-send-email-b42378@freescale.com> <20130814032658.GA16915@S2101-09.ap.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20130814032658.GA16915@S2101-09.ap.freescale.net> Sender: devicetree-owner@vger.kernel.org To: Shawn Guo Cc: Fabio Estevam , broonie@kernel.org, lars@metafoo.de, p.zabel@pengutronix.de, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, timur@tabi.org, rob.herring@calxeda.com List-ID: Hi Shwan, On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote: > I do not think we need this general compatible string. Device tree > compatible should be specific. So I should just use 'fsl,-spdif" and list all -spdif in compatible list? I added 'fsl,fsl-spdif' just for those not-in-list chips, Vybrid for example. So you think I should add all the possible chips to the list? But what if some chip I don't know right now that also uses this spdif controller? Add them to the list later? Thank you.