From: 'Joerg Roedel' <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
'Linux Samsung SOC'
<linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
'Prathyush' <prathyush.k-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
'Grant Grundler'
<grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
'Subash Patel'
<supash.ramaswamy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
'Linux Kernel'
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
'Sachin Kamat'
<sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
'Linux IOMMU'
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
'Kukjin Kim' <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
'Antonios Motakis'
<a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>,
Cho KyongHo <pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org,
'Linux ARM Kernel'
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
'Rahul Sharma'
<rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab
Date: Wed, 14 Aug 2013 12:56:16 +0200 [thread overview]
Message-ID: <20130814105615.GG4491@8bytes.org> (raw)
In-Reply-To: <2101296.S6JDU5igl3@flatron>
On Fri, Aug 09, 2013 at 09:55:30AM +0200, Tomasz Figa wrote:
> Oh, this is a valid point, but it was more a nitpick about the coding
> style. Single path error handling (with goto) is widely used in the kernel
> in cases when more than one thing has to be undone and so I suggested this
> method of error handling here as well.
I agree with that review from Tomasz, the error-handling should look
similar to all the other places in the kernel and use goto.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org ('Joerg Roedel')
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab
Date: Wed, 14 Aug 2013 12:56:16 +0200 [thread overview]
Message-ID: <20130814105615.GG4491@8bytes.org> (raw)
In-Reply-To: <2101296.S6JDU5igl3@flatron>
On Fri, Aug 09, 2013 at 09:55:30AM +0200, Tomasz Figa wrote:
> Oh, this is a valid point, but it was more a nitpick about the coding
> style. Single path error handling (with goto) is widely used in the kernel
> in cases when more than one thing has to be undone and so I suggested this
> method of error handling here as well.
I agree with that review from Tomasz, the error-handling should look
similar to all the other places in the kernel and use goto.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: "'Joerg Roedel'" <joro@8bytes.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Cho KyongHo <pullip.cho@samsung.com>,
Tomasz Figa <t.figa@samsung.com>,
"'Linux ARM Kernel'" <linux-arm-kernel@lists.infradead.org>,
"'Linux IOMMU'" <iommu@lists.linux-foundation.org>,
"'Linux Kernel'" <linux-kernel@vger.kernel.org>,
"'Linux Samsung SOC'" <linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org,
"'Kukjin Kim'" <kgene.kim@samsung.com>,
"'Prathyush'" <prathyush.k@samsung.com>,
"'Rahul Sharma'" <rahul.sharma@samsung.com>,
"'Subash Patel'" <supash.ramaswamy@linaro.org>,
"'Grant Grundler'" <grundler@chromium.org>,
"'Antonios Motakis'" <a.motakis@virtualopensystems.com>,
kvmarm@lists.cs.columbia.edu,
"'Sachin Kamat'" <sachin.kamat@linaro.org>
Subject: Re: [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab
Date: Wed, 14 Aug 2013 12:56:16 +0200 [thread overview]
Message-ID: <20130814105615.GG4491@8bytes.org> (raw)
In-Reply-To: <2101296.S6JDU5igl3@flatron>
On Fri, Aug 09, 2013 at 09:55:30AM +0200, Tomasz Figa wrote:
> Oh, this is a valid point, but it was more a nitpick about the coding
> style. Single path error handling (with goto) is widely used in the kernel
> in cases when more than one thing has to be undone and so I suggested this
> method of error handling here as well.
I agree with that review from Tomasz, the error-handling should look
similar to all the other places in the kernel and use goto.
Joerg
next prev parent reply other threads:[~2013-08-14 10:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 9:38 [PATCH v9 04/16] iommu/exynos: allocate lv2 page table from own slab Cho KyongHo
2013-08-08 9:38 ` Cho KyongHo
2013-08-08 9:38 ` Cho KyongHo
2013-08-08 14:00 ` Tomasz Figa
2013-08-08 14:00 ` Tomasz Figa
2013-08-09 5:58 ` Cho KyongHo
2013-08-09 5:58 ` Cho KyongHo
2013-08-09 5:58 ` Cho KyongHo
[not found] ` <20130809145849.790a9800f4f9893b30e54a1c-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-08-09 7:55 ` Tomasz Figa
2013-08-09 7:55 ` Tomasz Figa
2013-08-09 7:55 ` Tomasz Figa
2013-08-09 8:51 ` Cho KyongHo
2013-08-09 8:51 ` Cho KyongHo
2013-08-09 8:51 ` Cho KyongHo
2013-08-09 9:35 ` Tomasz Figa
2013-08-09 9:35 ` Tomasz Figa
2013-08-12 1:59 ` Cho KyongHo
2013-08-12 1:59 ` Cho KyongHo
2013-08-12 1:59 ` Cho KyongHo
2013-08-14 10:56 ` 'Joerg Roedel' [this message]
2013-08-14 10:56 ` 'Joerg Roedel'
2013-08-14 10:56 ` 'Joerg Roedel'
[not found] ` <20130814105615.GG4491-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-08-16 11:17 ` Cho KyongHo
2013-08-16 11:17 ` Cho KyongHo
2013-08-16 11:17 ` Cho KyongHo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814105615.GG4491@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grundler-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=prathyush.k-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=supash.ramaswamy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.