From: "Serge E. Hallyn" <serge@hallyn.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Serge Hallyn <serge.hallyn@canonical.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] efs: iget_locked() doesn't return an ERR_PTR()
Date: Wed, 14 Aug 2013 11:57:57 +0000 [thread overview]
Message-ID: <20130814115757.GA16458@mail.hallyn.com> (raw)
In-Reply-To: <20130814094940.GF521@elgon.mountain>
Quoting Dan Carpenter (dan.carpenter@oracle.com):
> The iget_locked() function returns NULL on error and never an ERR_PTR.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> diff --git a/fs/efs/inode.c b/fs/efs/inode.c
> index f3913eb..d15ccf2 100644
> --- a/fs/efs/inode.c
> +++ b/fs/efs/inode.c
> @@ -57,7 +57,7 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino)
> struct inode *inode;
>
> inode = iget_locked(super, ino);
> - if (IS_ERR(inode))
> + if (!inode)
> return ERR_PTR(-ENOMEM);
> if (!(inode->i_state & I_NEW))
> return inode;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2013-08-14 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 9:49 [patch] efs: iget_locked() doesn't return an ERR_PTR() Dan Carpenter
2013-08-14 9:49 ` Dan Carpenter
2013-08-14 11:57 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814115757.GA16458@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=dan.carpenter@oracle.com \
--cc=ebiederm@xmission.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.