From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans-Christian Egtvedt Subject: Re: [PATCH 04/37] cpufreq: at32ap: don't initialize part of policy that is set by core too Date: Wed, 14 Aug 2013 16:35:35 +0200 Message-ID: <20130814143535.GB3263@samfundet.no> References: <6fe9b31a6e199052e0a91b38c8f6d110e9f57b28.1376486713.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <6fe9b31a6e199052e0a91b38c8f6d110e9f57b28.1376486713.git.viresh.kumar@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Viresh Kumar Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Around Wed 14 Aug 2013 19:01:53 +0530 or thereabout, Viresh Kumar wrote: > Many common initializations of struct policy are moved to core now and hence > this driver doesn't need to do it. This patch removes such code. > > Most recent of those changes is to call ->get() in the core after calling > ->init(). It would be easier to review if you add me to CC on the new APIs you implement as well. Now I had to look up what the ->get() call did. > Cc: Hans-Christian Egtvedt > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/at32ap-cpufreq.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) Assuming the core get() call replaces the content: Acked-by: Hans-Christian Egtvedt -- mvh Hans-Christian Egtvedt