From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44697)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1V9zsn-0001hY-5M
	for qemu-devel@nongnu.org; Thu, 15 Aug 2013 11:54:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1V9zsi-0000Nh-8B
	for qemu-devel@nongnu.org; Thu, 15 Aug 2013 11:54:41 -0400
Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:58989)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1V9zsi-0000NS-0b
	for qemu-devel@nongnu.org; Thu, 15 Aug 2013 11:54:36 -0400
Date: Thu, 15 Aug 2013 17:54:32 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130815155432.GA18987@ohm.aurel32.net>
References: <1375726045-20797-1-git-send-email-rth@twiddle.net>
	<1375726045-20797-2-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1375726045-20797-2-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH for-next 1/8] tcg-i386: Add and use
	tcg_out64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Mon, Aug 05, 2013 at 08:07:18AM -1000, Richard Henderson wrote:
> No point in splitting the write into 32-bit pieces.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/i386/tcg-target.c | 3 +--
>  tcg/tcg.c             | 6 ++++++
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index 87eeab3..841bd75 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -552,8 +552,7 @@ static void tcg_out_movi(TCGContext *s, TCGType type,
>          tcg_out32(s, arg);
>      } else {
>          tcg_out_opc(s, OPC_MOVL_Iv + P_REXW + LOWREGMASK(ret), 0, ret, 0);
> -        tcg_out32(s, arg);
> -        tcg_out32(s, arg >> 31 >> 1);
> +        tcg_out64(s, arg);
>      }
>  }
>  
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index dac8224..9355b57 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -131,6 +131,12 @@ static inline void tcg_out32(TCGContext *s, uint32_t v)
>      s->code_ptr += 4;
>  }
>  
> +static inline void tcg_out64(TCGContext *s, uint64_t v)
> +{
> +    *(uint64_t *)s->code_ptr = v;
> +    s->code_ptr += 8;
> +}
> +
>  /* label relocation processing */
>  
>  static void tcg_out_reloc(TCGContext *s, uint8_t *code_ptr, int type,

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net