From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Solaris / FreeBSD builds (was Re: [PATCH 0/3]
	stdinc-related build fixes.)
Date: Thu, 15 Aug 2013 16:55:33 +0100
Message-ID: <20130815155533.GC60836@ocelot.phlegethon.org>
References: <1376573107-27249-1-git-send-email-tim@xen.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1376573107-27249-1-git-send-email-tim@xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: xen-devel@lists.xen.org
Cc: keir@xen.org, ian.campbell@citrix.com, chegger@amazon.de, Ian.Jackson@eu.citrix.com, prlw1@cam.ac.uk, stefano.stabellini@citrix.com, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

At 14:25 +0100 on 15 Aug (1376576704), Tim Deegan wrote:
> I rather suspect that FreeBSD and Solaris ought to be treated the same
> way -- currently FreeBSD has no workarounds (but on a FreeBSD 5 box I
> see stdarg.h in /usr/include)

Yep, FreeBSD works with the same handling as the other BSDs.  (I just
sent a patch to do that.)

> and Solaris just drops the nostdinc (I have no Solaris box handy to test on).

Playing with a Solaris 10 VM (and gcc &c from opencsw) it looks like
'-nostdinc -iwithprefix include' should work fine there, i.e.:

diff --git a/xen/Rules.mk b/xen/Rules.mk
index bbfc1ac..bf870da 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -45,10 +45,7 @@ CFLAGS-y                += -fno-builtin -fno-common
 CFLAGS-y                += -Werror -Wredundant-decls -Wno-pointer-arith
 CFLAGS-y                += -pipe
 CFLAGS-y                += -g -D__XEN__ -include $(BASEDIR)/include/xen/config.h
-# Solaris puts stdarg.h &c in the system include directory.
-ifneq ($(XEN_OS),SunOS)
 CFLAGS-y                += -nostdinc -iwithprefix include
-endif
 
 CFLAGS-$(XSM_ENABLE)    += -DXSM_ENABLE
 CFLAGS-$(FLASK_ENABLE)  += -DFLASK_ENABLE -DXSM_MAGIC=0xf97cff8c


Sadly all I could find at short notice was 32-bit install media so I can't
actually test the x86_64 build.  

Does anyone from Oracle want to try it? :)

Cheers,

Tim.