All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: wang.bo116@zte.com.cn
Cc: artem.bityutskiy@linux.intel.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] UBIFS: remove unnecessary code in ubifs_garbage_collect
Date: Thu, 15 Aug 2013 18:15:29 -0300	[thread overview]
Message-ID: <20130815211528.GC2831@localhost> (raw)
In-Reply-To: <OF5D2B97A5.BBB53CFB-ON48257BC8.00312DE8-48257BC8.003BEE50@zte.com.cn>

Hi,

First of all: thanks for contributing!

On Thu, Aug 15, 2013 at 06:54:26PM +0800, wang.bo116@zte.com.cn wrote:
> 
> Hi,
> 	In ubifs_garbage_collect, "space_before" calculate twice, i think the
> first one is unnecessary.
> 

Mmm... this is not the way patches are contributed, although you were
close.

Please read: Documentation/SubmittingPatches and maybe see this video
as well:

http://www.youtube.com/watch?v=XXix80GCvpo

Thanks!

> 
> Signed-off-by: wang bo <wang.bo116@zte.com.cn>
> diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
> index 76ca53c..38dc67d 100755
> --- a/fs/ubifs/gc.c
> +++ b/fs/ubifs/gc.c
> @@ -668,7 +668,7 @@ int ubifs_garbage_collect(struct ubifs_info *c, int
> anyway)
>  	ubifs_assert(!wbuf->used);
> 
>  	for (i = 0; ; i++) {
> -		int space_before = c->leb_size - wbuf->offs - wbuf->used;
> +		int space_before;
>  		int space_after;
> 
>  		cond_resched();
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

  reply	other threads:[~2013-08-15 21:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 10:54 [PATCH] UBIFS: remove unnecessary code in ubifs_garbage_collect wang.bo116
2013-08-15 21:15 ` Ezequiel Garcia [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-08-16  7:43 wang.bo116
2013-09-17  1:51 ` Brian Norris
2013-10-19 13:27   ` Ezequiel Garcia
2013-10-22 14:44     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815211528.GC2831@localhost \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=wang.bo116@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.