Re: [PATCH] pinctrl: msm: Add support for MSM TLMM pinmux

[Josh Cartwright <joshc@codeaurora.org>]

On Thu, Aug 15, 2013 at 10:44:03AM -0700, Hanumant Singh wrote:
> On 8/14/2013 12:29 PM, Linus Walleij wrote:
> >On Tue, Jul 30, 2013 at 1:39 AM, Bjorn Andersson <bjorn@kryo.se> wrote:
> >>On Wed, Jul 24, 2013 at 1:41 PM, Hanumant Singh <hanumant@codeaurora.org> wrote:
> >
> >>As a general note on the patch, the pins and pin groups are defined by
> >>the soc, I'm therefore not convinced that these should be configured
> >>from the devicetree. It's at least not how it's done in other
> >>platforms.
> >
> >Now we are three people sayin the same thing so it should
> >be a good hint to the implementer :-)
> >
> 
> Ok i can switch to using pin groups defined in per soc files.
> But in our case we have one soc going into different types of boards.
> (atleast 3). In each of the boards the same external devices end up using
> different pins. For ex camera on board 1 uses different pin group
> then the same camera on board 2. Both having the same SOC.
> So in this case the design would be to have all possible pin groups
> for different boards enumerated in the same soc-pinctrl.c file?
> 
> Also in this implementation I will have.
> 1) pinctrl-msm.c => DT parsing and interface to framework.
> 2) pinctrl-msm-tlmm<version>.c => Register programming and pin types
> supported by a particular TLMM pinmux version.

It isn't clear to me what you are trying to separate out between 1) and
2).  Seems like there should only be pinctrl-msm-tlmm<version>.c.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation