From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>,
Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [PATCH, RFC] xfs: be more forgiving of a v4 secondary sb w/ junk in v5 fields
Date: Fri, 16 Aug 2013 09:15:22 +1000 [thread overview]
Message-ID: <20130815231522.GY6023@dastard> (raw)
In-Reply-To: <520D592D.4040600@redhat.com>
On Thu, Aug 15, 2013 at 05:41:49PM -0500, Eric Sandeen wrote:
> Today, if xfs_sb_read_verify encounters a v4 superblock
> with junk past v4 fields which includes data in sb_crc,
> it will be treated as a failing checksum and significant
> corruption.
>
> There are known prior bugs which leave junk at the end
> of the superblock; we don't need to actually fail the
> verification in this case if other checks pan out ok.
>
> So if this is a secondary superblock, and the primary
> superblock is not V5, don't treat this as a serious
> checksum failure.
>
> We should probably check the garbage condition as
> we do in xfs_repair, and possibly warn about it
> or self-heal, but that's a different scope of work.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Fine by me.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-15 23:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 18:19 [PATCH, RFC] xfs: don't verify checksum on non-V5 superblocks Eric Sandeen
2013-08-15 19:45 ` Ben Myers
2013-08-15 21:00 ` Dave Chinner
2013-08-15 21:15 ` Eric Sandeen
2013-08-15 22:41 ` [PATCH, RFC] xfs: be more forgiving of a v4 secondary sb w/ junk in v5 fields Eric Sandeen
2013-08-15 23:15 ` Dave Chinner [this message]
2013-09-09 20:33 ` [PATCH V2] " Eric Sandeen
2013-09-09 21:08 ` Mark Tinguely
2013-09-09 21:10 ` Eric Sandeen
2013-09-09 21:16 ` Mark Tinguely
2013-10-31 15:51 ` Ben Myers
2013-10-17 20:17 ` [PATCH, RFC] " Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815231522.GY6023@dastard \
--to=david@fromorbit.com \
--cc=linux-xfs@oss.sgi.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.