From: Stephen Hemminger <stephen@networkplumber.org>
To: Martin Schwenke <martin@meltin.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ip monitor: Enable prefix labels when monitoring more than 1 object
Date: Thu, 15 Aug 2013 23:40:47 -0700 [thread overview]
Message-ID: <20130815234047.0018f3dd@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20130815070527.1df23bea@martins.ozlabs.org>
On Thu, 15 Aug 2013 07:05:27 +1000
Martin Schwenke <martin@meltin.net> wrote:
> Prefix labelling is currently only activated when monitoring "all"
> objects. However, the output can still be confusing when monitoring
> more than 1 object, so enable prefix labels in this case.
>
> Signed-off-by: Martin Schwenke <martin@meltin.net>
I understand where you are coming from, but changing the output format
might break people with scripts doing parsing the current format.
Since there is already a flag to ip monitor to put on prefix labels,
why not just use that if you need to?
This seems like a change likely to upset more people than it pleases.
next prev parent reply other threads:[~2013-08-16 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 21:05 [PATCH] ip monitor: Enable prefix labels when monitoring more than 1 object Martin Schwenke
2013-08-16 6:40 ` Stephen Hemminger [this message]
2013-08-16 6:52 ` Martin Schwenke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815234047.0018f3dd@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=martin@meltin.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.