From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jens Frederich <jfrederich@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
jon.nettleton@gmail.com, dsd@laptop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Staging: olpc_dcon: replace some magic numbers
Date: Fri, 16 Aug 2013 10:13:38 +0300 [thread overview]
Message-ID: <20130816071338.GC26086@mwanda> (raw)
In-Reply-To: <1376595295-7820-1-git-send-email-jfrederich@gmail.com>
On Thu, Aug 15, 2013 at 09:34:55PM +0200, Jens Frederich wrote:
> The 0x42 initialize squence 0x101 is wrong. According to
> the specification Bit 8 is reserved, thus not in use.
> I removed it.
Really these code changes should be in a separate patch and labeled
"Don't set reserved bit." instead of hidden away inside a cleanup
patch.
regards,
dan carpenter
next prev parent reply other threads:[~2013-08-16 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 19:34 [PATCH 2/3] Staging: olpc_dcon: replace some magic numbers Jens Frederich
2013-08-16 7:13 ` Dan Carpenter [this message]
2013-08-16 7:40 ` Jens Frederich
2013-08-16 8:54 ` Dan Carpenter
2013-08-16 11:04 ` Jens Frederich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816071338.GC26086@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dsd@laptop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jfrederich@gmail.com \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.