From: Josef Bacik <jbacik@fusionio.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: Josef Bacik <jbacik@fusionio.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: stop using GFP_ATOMIC when allocating rewind ebs
Date: Fri, 16 Aug 2013 10:05:22 -0400 [thread overview]
Message-ID: <20130816140522.GA3990@localhost.localdomain> (raw)
In-Reply-To: <520E0F09.1050604@giantdisaster.de>
On Fri, Aug 16, 2013 at 01:37:45PM +0200, Stefan Behrens wrote:
> On Wed, 7 Aug 2013 17:11:49 -0400, Josef Bacik wrote:
> > There is no reason we can't just set the path to blocking and then do normal
> > GFP_NOFS allocations for these extent buffers. Thanks,
> >
> > Signed-off-by: Josef Bacik <jbacik@fusionio.com>
>
> You've forgotten at least one place.
>
> static inline struct extent_buffer *
> get_old_root(struct btrfs_root *root, u64 time_seq)
> {
> ...
> eb_root = btrfs_read_lock_root_node(root);
> ...
> } else {
> eb = btrfs_clone_extent_buffer(eb_root);
> btrfs_tree_read_unlock(eb_root);
>
>
> The xfstest btrfs/004 (backref testing) discovered this issue in the
> context of ioctl(BTRFS_IOC_LOGICAL_INO).
>
Ah excellent, thanks. I will fix this up right now.
Josef
prev parent reply other threads:[~2013-08-16 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 21:11 [PATCH] Btrfs: stop using GFP_ATOMIC when allocating rewind ebs Josef Bacik
2013-08-08 7:23 ` Jan Schmidt
2013-08-08 13:12 ` Josef Bacik
2013-08-08 13:19 ` Jan Schmidt
2013-08-16 11:37 ` Stefan Behrens
2013-08-16 14:05 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816140522.GA3990@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.