From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, majianpeng <majianpeng@gmail.com>,
Lukas Czerner <lczerner@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix oops in jbd2_journal_file_inode()
Date: Fri, 16 Aug 2013 21:24:02 -0400 [thread overview]
Message-ID: <20130817012402.GA9349@thunk.org> (raw)
In-Reply-To: <1375886476-26805-1-git-send-email-jack@suse.cz>
On Wed, Aug 07, 2013 at 04:41:16PM +0200, Jan Kara wrote:
> Commit 0713ed0cde76438d05849f1537d3aab46e099475 added
> jbd2_journal_file_inode() call into ext4_block_zero_page_range().
> However that function gets called from truncate path and thus inode
> needn't have jinode attached - that happens in ext4_file_open() but the
> file needn't be ever open since mount. Calling jbd2_journal_file_inode()
> without jinode attached results in the oops.
>
> We fix the problem by attaching jinode to inode also in ext4_truncate()
> and ext4_punch_hole() when we are going to zero out partial blocks.
>
> CC: <stable@vger.kernel.org> (from 3.10)
> Reported-by: majianpeng <majianpeng@gmail.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, applied. I've removed the cc: stable since commit
0713ed0cde764 didn't show up until v3.11-rc1.
- Ted
prev parent reply other threads:[~2013-08-17 1:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 14:41 [PATCH] ext4: Fix oops in jbd2_journal_file_inode() Jan Kara
2013-08-17 1:24 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130817012402.GA9349@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=majianpeng@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.