From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAYyj-00037L-C4 for qemu-devel@nongnu.org; Sat, 17 Aug 2013 01:23:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAYya-0008GV-Ft for qemu-devel@nongnu.org; Sat, 17 Aug 2013 01:23:09 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:49688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAYyZ-0008GF-Qc for qemu-devel@nongnu.org; Sat, 17 Aug 2013 01:23:00 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 17 Aug 2013 15:09:22 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 1452D2BB004F for ; Sat, 17 Aug 2013 15:22:40 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7H56SLL63635530 for ; Sat, 17 Aug 2013 15:06:38 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r7H5MTXg003070 for ; Sat, 17 Aug 2013 15:22:29 +1000 Date: Sat, 17 Aug 2013 10:52:34 +0530 From: Bharata B Rao Message-ID: <20130817052234.GF4126@in.ibm.com> References: <1376668044-25116-1-git-send-email-stefanha@redhat.com> <1376668044-25116-9-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 08/18] block/gluster: drop qemu_gluster_aio_flush_cb() Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , qemu-devel@nongnu.org > From: Stefan Hajnoczi > Since .io_flush() is no longer called we do not need > qemu_gluster_aio_flush_cb() anymore. It turns out that qemu_aio_count > is unused now and can be dropped. > > Signed-off-by: Stefan Hajnoczi Tested-by: Bharata B Rao Tested GlusterFS backend, but it needed the below fix: ------ gluster: Remove the use of qemu_aio_count from gluster discard qemu_aio_count is no longer used and hence remove its usage from qemu_gluster_aio_discard() Signed-off-by: Bharata B Rao --- block/gluster.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index fbdbe97..46f36f8 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -548,7 +548,6 @@ static BlockDriverAIOCB *qemu_gluster_aio_discard(BlockDriverState *bs, acb->size = 0; acb->ret = 0; acb->finished = NULL; - s->qemu_aio_count++; ret = glfs_discard_async(s->fd, offset, size, &gluster_finish_aiocb, acb); if (ret < 0) { @@ -557,7 +556,6 @@ static BlockDriverAIOCB *qemu_gluster_aio_discard(BlockDriverState *bs, return &acb->common; out: - s->qemu_aio_count--; qemu_aio_release(acb); return NULL; }