Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

["Zubair Lutfullah :" <zubair.lutfullah@gmail.com>]

On Sat, Aug 17, 2013 at 04:15:33PM +0100, Jonathan Cameron wrote:
> > I restructure the driver so that
> > enabling the buffer via userspace starts sampling the ADC channels.
> > Preenable/postenable do all that hard work.
> > 
> > I need to use iio_trigger_register to create an IIO trigger inside the
> > driver.
> > 
> > The IRQ handler for FIFO Threshold causes a trigger event.
> > 
> > The trigger handler pushes the entire fifo to userspace.
> > 
> > I'd like a small ACK before I get to work.
> > Just to make sure I got things correctly.
> Sounds right.
> 
> As I said above, in this case it would be perfectly acceptable to
> not expose the trigger at all (e.g. drive the buffer filling directly)
> as we can't use it for any other purposes anyway and using any other
> trigger to drive this part doesn't make much sense.
>

Not exposing the trigger would require workarounds for generic_buffer.c
and I'd like to avoid that. Its pretty harmless to have it anyways.

Thanks for the ACK. I'll send another series in a while after all this.

Zubair