From: Ingo Molnar <mingo@kernel.org>
To: Youquan Song <youquan.song@linux.intel.com>
Cc: Yinghai Lu <yinghai@kernel.org>, Gleb Natapov <gleb@redhat.com>,
Youquan Song <youquan.song@intel.com>,
Sheng Yang <sheng@linux.intel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native
Date: Mon, 19 Aug 2013 09:11:28 +0200 [thread overview]
Message-ID: <20130819071128.GA26184@gmail.com> (raw)
In-Reply-To: <20130817195232.GA22050@linux-youquan.bj.intel.com>
* Youquan Song <youquan.song@linux.intel.com> wrote:
> > Firstly, please use the customary (multi-line) comment
> > style:
> >
> > /*
> > * Comment .....
> > * ...... goes here.
> > */
> >
> > specified in Documentation/CodingStyle.
> >
> > Secondly, please send a patch against a vanilla (e.g.
> > v3.11-rc5) kernel, as I've already zapped your previous
> > patch from tip:x86/apic per your request.
> Hi Ingo,
>
> latest vanilla has no includes the patch yet, so I think it
> will be fine by only dropping it from tip tree.
I know that it's not included yet - because I have not sent
it to Linus.
My suggestion was to document the circumstances here via a
single patch, i.e. not a patch + revert-and-add-comments
patch, but via a simple add-comments patch. Agreed?
Thanks,
Ingo
next prev parent reply other threads:[~2013-08-19 7:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 1:22 [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native Youquan Song
2013-07-23 9:17 ` Ingo Molnar
2013-07-24 14:04 ` Youquan Song
2013-07-25 22:01 ` Ingo Molnar
2013-07-29 16:48 ` Youquan Song
2013-07-24 3:55 ` [tip:x86/apic] x86/apic: Enable x2APIC physical mode on native hardware too, when there are fewer than 256 CPUs tip-bot for Youquan Song
2013-07-24 4:24 ` [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native Yinghai Lu
2013-07-24 6:22 ` Gleb Natapov
2013-07-25 14:05 ` Yinghai Lu
2013-07-29 17:05 ` Youquan Song
2013-08-14 18:40 ` Youquan Song
2013-08-14 11:11 ` Ingo Molnar
2013-08-17 13:44 ` Youquan Song
2013-08-17 7:42 ` Ingo Molnar
2013-08-17 8:24 ` Borislav Petkov
2013-08-17 9:03 ` Joe Perches
2013-08-17 15:44 ` Borislav Petkov
2013-08-17 16:26 ` Joe Perches
2013-08-18 10:02 ` Borislav Petkov
2013-08-17 19:52 ` Youquan Song
2013-08-19 7:11 ` Ingo Molnar [this message]
2013-08-02 19:12 ` Konrad Rzeszutek Wilk
2013-07-24 14:45 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819071128.GA26184@gmail.com \
--to=mingo@kernel.org \
--cc=gleb@redhat.com \
--cc=hpa@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sheng@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.