Re: [uml-devel] [PATCH 3/4] um: Cleanup SIGTERM handling

["Richard W.M. Jones" <rjones@redhat.com>]

On Sun, Aug 18, 2013 at 01:30:08PM +0200, Richard Weinberger wrote:
> Richard reported that some UML processes survive if the UML
> main process receives a SIGTERM.
> This issue was caused by a wrongly placed signal(SIGTERM, SIG_DFL)
> in init_new_thread_signals().
> It disabled the UML exit handler accidently for some processes.
> The correct solution is to disable the fatal handler for all
> UML helper threads/processes.
> Such that last_ditch_exit() does not get called multiple times
> and all processes can exit due to SIGTERM.
> 
> Cc: rjones@redhat.com
> Reported-by: Richard W.M. Jones <rjones@redhat.com>
> Signed-off-by: Richard Weinberger <richard@nod.at>

I tested this using the libguestfs UML backend, and the original
problem with not all processes being cleared up on exit has been fixed.

I also observed that the exit status has changed from "killed by
SIGTERM" to exit code 1.  Therefore:

Tested-by: Richard W.M. Jones <rjones@redhat.com>

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel