All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] perf ui/gtk: Separate out GTK code to a shared object (v4)
Date: Mon, 19 Aug 2013 11:05:00 -0300	[thread overview]
Message-ID: <20130819140500.GA3053@ghostprotocols.net> (raw)
In-Reply-To: <1376029689-32593-1-git-send-email-namhyung@kernel.org>

Em Fri, Aug 09, 2013 at 03:28:06PM +0900, Namhyung Kim escreveu:
> This is v3 of gtk code separation patchset to reduce library

Not a major problem, but would be good if we were robust in this area:

    LINK /tmp/build/perf/perf
/usr/bin/ld: /tmp/build/perf/ui/gtk/browser.o: relocation R_X86_64_32
against `.rodata.str1.1' can not be used when making a shared object;
recompile with -fPIC
/tmp/build/perf/ui/gtk/browser.o: could not read symbols: Bad value
collect2: error: ld returned 1 exit status
make: *** [/tmp/build/perf/libperf-gtk.so] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/home/git/linux/tools/perf'
[acme@zoo linux]$ 

This happened because I was retesting the whole series after noticing I
was testing as root, that has a symlink of ~acme/bin/perf to
~root/bin/perf but was lacking a symlink of ~acme/lib64/ to
~root/lib64/, so that as root perf could find the libperf-gtk.so file.

So I just rolled back the 3 patches in this series to rebuild and
retried, but when I reapplied the first patch in this series I got the
above error, i.e. the make process got confused and didn't properly
rebuilt a file in the expected format for linking, after forcefully
removing my build dir and rebuilding everything it got back to working.

But I expected that after the first patch 'perf --gtk' would work, and
it doesn't.

Now even after I applied the whole series I don't get --gtk to work,
neither as a non-root nor as root :-\

Investigating...

- Arnaldo

  parent reply	other threads:[~2013-08-19 14:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09  6:28 [PATCH 0/3] perf ui/gtk: Separate out GTK code to a shared object (v4) Namhyung Kim
2013-08-09  6:28 ` [PATCH 1/3] perf tools: Separate out GTK codes to libperf-gtk.so Namhyung Kim
2013-08-09  6:28 ` [PATCH 2/3] perf tools: Setup GTK browser dynamically Namhyung Kim
2013-08-09  6:28 ` [PATCH 3/3] perf tools: Run dynamic loaded GTK browser Namhyung Kim
2013-08-19 14:05 ` Arnaldo Carvalho de Melo [this message]
2013-08-19 15:17   ` [PATCH 0/3] perf ui/gtk: Separate out GTK code to a shared object (v4) Arnaldo Carvalho de Melo
2013-08-27  8:03     ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130819140500.GA3053@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.