From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Mon, 19 Aug 2013 07:37:52 -0700 Subject: [Cluster-devel] [Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions In-Reply-To: <1376907278-26377-8-git-send-email-amwang@redhat.com> References: <1376907278-26377-1-git-send-email-amwang@redhat.com> <1376907278-26377-8-git-send-email-amwang@redhat.com> Message-ID: <20130819143752.GA12266@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > @@ -1900,17 +1901,9 @@ srcip_matches(struct sockaddr *srcaddr, struct sockaddr *rhs) > { I think your new sockaddr_equal should be equivalent to to this srcip_matches, that is it should warn about and return false for unknown address families. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions Date: Mon, 19 Aug 2013 07:37:52 -0700 Message-ID: <20130819143752.GA12266@infradead.org> References: <1376907278-26377-1-git-send-email-amwang@redhat.com> <1376907278-26377-8-git-send-email-amwang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S. Miller" , Steve French , Christine Caulfield , David Teigland , Trond Myklebust , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Cong Wang Return-path: Content-Disposition: inline In-Reply-To: <1376907278-26377-8-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-cifs.vger.kernel.org > @@ -1900,17 +1901,9 @@ srcip_matches(struct sockaddr *srcaddr, struct sockaddr *rhs) > { I think your new sockaddr_equal should be equivalent to to this srcip_matches, that is it should warn about and return false for unknown address families. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:35686 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811Ab3HSOh4 (ORCPT ); Mon, 19 Aug 2013 10:37:56 -0400 Date: Mon, 19 Aug 2013 07:37:52 -0700 From: Christoph Hellwig To: Cong Wang Cc: netdev@vger.kernel.org, "David S. Miller" , Steve French , Christine Caulfield , David Teigland , Trond Myklebust , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org Subject: Re: [Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions Message-ID: <20130819143752.GA12266@infradead.org> References: <1376907278-26377-1-git-send-email-amwang@redhat.com> <1376907278-26377-8-git-send-email-amwang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1376907278-26377-8-git-send-email-amwang@redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: > @@ -1900,17 +1901,9 @@ srcip_matches(struct sockaddr *srcaddr, struct sockaddr *rhs) > { I think your new sockaddr_equal should be equivalent to to this srcip_matches, that is it should warn about and return false for unknown address families.