From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Barry Song <21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
workgroup.linux-kQvG35nSl+M@public.gmane.org,
Zhiwu Song <Zhiwu.Song-kQvG35nSl+M@public.gmane.org>,
Barry Song <Baohua.Song-kQvG35nSl+M@public.gmane.org>
Subject: Re: [PATCH 1/5] i2c: sirf: reset i2c controller early after we get a noack
Date: Mon, 19 Aug 2013 20:05:40 +0200 [thread overview]
Message-ID: <20130819180540.GD8626@katana> (raw)
In-Reply-To: <1376385091-30597-2-git-send-email-Baohua.Song-kQvG35nSl+M@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 151 bytes --]
> + while (readl(siic->base + SIRFSOC_I2C_CTRL) & SIRFSOC_I2C_RESET)
> + cpu_relax();
Are you sure you want no timeout here? Same for patch 2/5.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-19 18:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 9:11 [PATCH 0/5] i2c: sirf: a bundle of fixes for stability Barry Song
[not found] ` <1376385091-30597-1-git-send-email-Baohua.Song-kQvG35nSl+M@public.gmane.org>
2013-08-13 9:11 ` [PATCH 1/5] i2c: sirf: reset i2c controller early after we get a noack Barry Song
[not found] ` <1376385091-30597-2-git-send-email-Baohua.Song-kQvG35nSl+M@public.gmane.org>
2013-08-19 18:05 ` Wolfram Sang [this message]
2013-08-19 22:49 ` Barry Song
2013-08-13 9:11 ` [PATCH 2/5] i2c: sirf: we need to wait I2C_RESET status in resume Barry Song
2013-08-13 9:11 ` [PATCH 3/5] i2c: sirf: fix the typo for setting bitrate to less than 100k Barry Song
2013-08-13 9:11 ` [PATCH 4/5] i2c: sirfsoc: support reverse direction of address Barry Song
[not found] ` <1376385091-30597-5-git-send-email-Baohua.Song-kQvG35nSl+M@public.gmane.org>
2013-08-19 18:06 ` Wolfram Sang
2013-08-20 2:30 ` Barry Song
[not found] ` <CAGsJ_4xoPCJyWZ=_nN6wZBAy2qMER=cKOqY_t8K_jAX8fZWGmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-28 9:41 ` Wolfram Sang
2013-08-28 12:00 ` Barry Song
2013-08-13 9:11 ` [PATCH 5/5] i2c: sirf: retry 3 times as sometimes we get random noack and timeout Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819180540.GD8626@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=Baohua.Song-kQvG35nSl+M@public.gmane.org \
--cc=Zhiwu.Song-kQvG35nSl+M@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=workgroup.linux-kQvG35nSl+M@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.