From: Jerry Snitselaar <jerry.snitselaar@oracle.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
Date: Mon, 19 Aug 2013 16:35:29 -0700 [thread overview]
Message-ID: <20130819233528.GA4587@cantor.us.oracle.com> (raw)
In-Reply-To: <2870377.GVGv4QBgQK@vostro.rjw.lan>
On Tue Aug 20 13, Rafael J. Wysocki wrote:
> On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > Without MODULE_LICENSE set, I get the following with modprobe:
> > >
> > > acpi_i2c: module license 'unspecified' taints kernel.
> > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > >
> > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> >
> > Looks good to me.
> >
> > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
>
> Well, OK, but do we need to be able to build that as a module?
>
> Maybe it should just be yes or no?
>
> Rafael
>
Perhaps have depends on I2C=y and be a bool instead of tristate?
next prev parent reply other threads:[~2013-08-19 23:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 1:26 [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION Jerry Snitselaar
2013-08-19 6:16 ` Mika Westerberg
2013-08-19 23:30 ` Rafael J. Wysocki
2013-08-19 23:35 ` Jerry Snitselaar [this message]
2013-08-19 23:48 ` Rafael J. Wysocki
2013-08-20 3:34 ` Jerry Snitselaar
2013-08-20 7:28 ` Mika Westerberg
2013-08-20 8:00 ` Jerry Snitselaar
2013-08-20 8:14 ` Mika Westerberg
2013-08-20 8:18 ` Mika Westerberg
2013-08-20 12:38 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2013-08-16 21:40 Jerry Snitselaar
2013-08-17 5:12 ` Jerry Snitselaar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819233528.GA4587@cantor.us.oracle.com \
--to=jerry.snitselaar@oracle.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.