From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf trace: Make command line arguments consistent with perf-record
Date: Tue, 20 Aug 2013 11:51:56 -0300 [thread overview]
Message-ID: <20130820145156.GC8488@ghostprotocols.net> (raw)
In-Reply-To: <1377010076-21509-1-git-send-email-dsahern@gmail.com>
Em Tue, Aug 20, 2013 at 08:47:56AM -0600, David Ahern escreveu:
> Common arguments like thread id, CPU list, mmap pages, etc should be
> consistent across perf commands.
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> tools/perf/builtin-trace.c | 12 ++++++------
tools/perf/Documentation/perf-trace.txt part missing :-)
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 4235316..9891d8c 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -693,17 +693,17 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)
> OPT_STRING('o', "output", &output_name, "file", "output file name"),
> OPT_STRING('p', "pid", &trace.opts.target.pid, "pid",
> "trace events on existing process id"),
> - OPT_STRING(0, "tid", &trace.opts.target.tid, "tid",
> + OPT_STRING('t', "tid", &trace.opts.target.tid, "tid",
> "trace events on existing thread id"),
> - OPT_BOOLEAN(0, "all-cpus", &trace.opts.target.system_wide,
> + OPT_BOOLEAN('a', "all-cpus", &trace.opts.target.system_wide,
> "system-wide collection from all CPUs"),
> - OPT_STRING(0, "cpu", &trace.opts.target.cpu_list, "cpu",
> + OPT_STRING('C', "cpu", &trace.opts.target.cpu_list, "cpu",
> "list of cpus to monitor"),
> - OPT_BOOLEAN(0, "no-inherit", &trace.opts.no_inherit,
> + OPT_BOOLEAN('i', "no-inherit", &trace.opts.no_inherit,
> "child tasks do not inherit counters"),
> - OPT_UINTEGER(0, "mmap-pages", &trace.opts.mmap_pages,
> + OPT_UINTEGER('m', "mmap-pages", &trace.opts.mmap_pages,
> "number of mmap data pages"),
> - OPT_STRING(0, "uid", &trace.opts.target.uid_str, "user",
> + OPT_STRING('u', "uid", &trace.opts.target.uid_str, "user",
> "user to profile"),
> OPT_CALLBACK(0, "duration", &trace, "float",
> "show only events with duration > N.M ms",
> --
> 1.7.10.1
next prev parent reply other threads:[~2013-08-20 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 14:47 [PATCH] perf trace: Make command line arguments consistent with perf-record David Ahern
2013-08-20 14:51 ` Arnaldo Carvalho de Melo [this message]
2013-08-20 16:22 ` David Ahern
2013-08-20 17:11 ` Arnaldo Carvalho de Melo
2013-08-20 17:19 ` David Ahern
-- strict thread matches above, loose matches on Subject: below --
2013-08-19 17:04 David Ahern
2013-08-19 19:06 ` Arnaldo Carvalho de Melo
2013-08-20 14:19 ` David Ahern
2013-08-20 14:43 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820145156.GC8488@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.