From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v4 06/19] driver/core: cpu: initialize of_node in cpu's device struture Date: Tue, 20 Aug 2013 08:18:52 -0700 Message-ID: <20130820151852.GB18016@kroah.com> References: <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376991021-12160-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376991021-12160-7-git-send-email-Sudeep.KarkadaNagesha@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34144 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387Ab3HTPRD (ORCPT ); Tue, 20 Aug 2013 11:17:03 -0400 Content-Disposition: inline In-Reply-To: <1376991021-12160-7-git-send-email-Sudeep.KarkadaNagesha@arm.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sudeep KarkadaNagesha Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Viresh Kumar , Benjamin Herrenschmidt , Jonas Bonn , Michal Simek , "Rafael J. Wysocki" , Grant Likely , Rob Herring On Tue, Aug 20, 2013 at 10:30:08AM +0100, Sudeep KarkadaNagesha wrote: > From: Sudeep KarkadaNagesha > > CPUs are also registered as devices but the of_node in these cpu > devices are not initialized. Currently different drivers requiring > to access cpu device node are parsing the nodes themselves and > initialising the of_node in cpu device. > > The of_node in all the cpu devices needs to be initialized properly > and at one place. The best place to update this is CPU subsystem > driver when registering the cpu devices. > > The OF/DT core library now provides of_get_cpu_node to retrieve a cpu > device node for a given logical index by abstracting the architecture > specific details. > > This patch uses of_get_cpu_node to assign of_node when registering the > cpu devices. > > Cc: Greg Kroah-Hartman > Acked-by: Rob Herring > Signed-off-by: Sudeep KarkadaNagesha Acked-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by ozlabs.org (Postfix) with ESMTP id 2C18E2C010F for ; Wed, 21 Aug 2013 01:17:03 +1000 (EST) Date: Tue, 20 Aug 2013 08:18:52 -0700 From: Greg Kroah-Hartman To: Sudeep KarkadaNagesha Subject: Re: [PATCH v4 06/19] driver/core: cpu: initialize of_node in cpu's device struture Message-ID: <20130820151852.GB18016@kroah.com> References: <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376991021-12160-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376991021-12160-7-git-send-email-Sudeep.KarkadaNagesha@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1376991021-12160-7-git-send-email-Sudeep.KarkadaNagesha@arm.com> Cc: Jonas Bonn , devicetree@vger.kernel.org, Michal Simek , linux-pm@vger.kernel.org, Viresh Kumar , linux-kernel@vger.kernel.org, Rob Herring , "Rafael J. Wysocki" , Grant Likely , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Aug 20, 2013 at 10:30:08AM +0100, Sudeep KarkadaNagesha wrote: > From: Sudeep KarkadaNagesha > > CPUs are also registered as devices but the of_node in these cpu > devices are not initialized. Currently different drivers requiring > to access cpu device node are parsing the nodes themselves and > initialising the of_node in cpu device. > > The of_node in all the cpu devices needs to be initialized properly > and at one place. The best place to update this is CPU subsystem > driver when registering the cpu devices. > > The OF/DT core library now provides of_get_cpu_node to retrieve a cpu > device node for a given logical index by abstracting the architecture > specific details. > > This patch uses of_get_cpu_node to assign of_node when registering the > cpu devices. > > Cc: Greg Kroah-Hartman > Acked-by: Rob Herring > Signed-off-by: Sudeep KarkadaNagesha Acked-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Tue, 20 Aug 2013 08:18:52 -0700 Subject: [PATCH v4 06/19] driver/core: cpu: initialize of_node in cpu's device struture In-Reply-To: <1376991021-12160-7-git-send-email-Sudeep.KarkadaNagesha@arm.com> References: <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376991021-12160-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376991021-12160-7-git-send-email-Sudeep.KarkadaNagesha@arm.com> Message-ID: <20130820151852.GB18016@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Aug 20, 2013 at 10:30:08AM +0100, Sudeep KarkadaNagesha wrote: > From: Sudeep KarkadaNagesha > > CPUs are also registered as devices but the of_node in these cpu > devices are not initialized. Currently different drivers requiring > to access cpu device node are parsing the nodes themselves and > initialising the of_node in cpu device. > > The of_node in all the cpu devices needs to be initialized properly > and at one place. The best place to update this is CPU subsystem > driver when registering the cpu devices. > > The OF/DT core library now provides of_get_cpu_node to retrieve a cpu > device node for a given logical index by abstracting the architecture > specific details. > > This patch uses of_get_cpu_node to assign of_node when registering the > cpu devices. > > Cc: Greg Kroah-Hartman > Acked-by: Rob Herring > Signed-off-by: Sudeep KarkadaNagesha Acked-by: Greg Kroah-Hartman