* About perf,arm -- oops in validate_event
@ 2013-08-20 10:03 P J P
2013-08-20 10:39 ` Catalin Marinas
0 siblings, 1 reply; 4+ messages in thread
From: P J P @ 2013-08-20 10:03 UTC (permalink / raw)
To: linux-kernel; +Cc: vincent.weaver
Hello,
-> https://lkml.org/lkml/2013/8/7/259
I wanted to confirm if this above fix should also go into ARM64 build Or is
ARM64 platform not vulnerable?
===
$ git diff
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 9ba33c4..cbed82f 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -317,6 +317,9 @@ validate_event(struct pmu_hw_events *hw_events,
struct hw_perf_event fake_event = event->hw;
struct pmu *leader_pmu = event->group_leader->pmu;
+ if (is_software_event(event))
+ return 1;
+
if (event->pmu != leader_pmu || event->state <= PERF_EVENT_STATE_OFF)
return 1;
===
Thank you.
--
Prasad J Pandit / Red Hat Security Response Team
DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602B
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: About perf,arm -- oops in validate_event
2013-08-20 10:03 About perf,arm -- oops in validate_event P J P
@ 2013-08-20 10:39 ` Catalin Marinas
2013-08-20 14:42 ` Vince Weaver
0 siblings, 1 reply; 4+ messages in thread
From: Catalin Marinas @ 2013-08-20 10:39 UTC (permalink / raw)
To: P J P; +Cc: Linux Kernel Mailing List, vincent.weaver
On 20 August 2013 11:03, P J P <ppandit@redhat.com> wrote:
> -> https://lkml.org/lkml/2013/8/7/259
>
> I wanted to confirm if this above fix should also go into ARM64 build Or is
> ARM64 platform not vulnerable?
It is and I'll push patches to mainline (Will is preparing them).
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: About perf,arm -- oops in validate_event
2013-08-20 10:39 ` Catalin Marinas
@ 2013-08-20 14:42 ` Vince Weaver
2013-08-20 16:15 ` Catalin Marinas
0 siblings, 1 reply; 4+ messages in thread
From: Vince Weaver @ 2013-08-20 14:42 UTC (permalink / raw)
To: Catalin Marinas; +Cc: P J P, Linux Kernel Mailing List
On Tue, 20 Aug 2013, Catalin Marinas wrote:
> On 20 August 2013 11:03, P J P <ppandit@redhat.com> wrote:
> > -> https://lkml.org/lkml/2013/8/7/259
> >
> > I wanted to confirm if this above fix should also go into ARM64 build Or is
> > ARM64 platform not vulnerable?
>
> It is and I'll push patches to mainline (Will is preparing them).
You'll probably also want the equivalent of
d9f966357b14e356dbd83b8f4a197a287ab4ff83
as well since arch/arm64/kernel/perf_event.c
has the same overflow in armpmu_map_event that is fixed in the mentioned
commit.
Vince
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: About perf,arm -- oops in validate_event
2013-08-20 14:42 ` Vince Weaver
@ 2013-08-20 16:15 ` Catalin Marinas
0 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2013-08-20 16:15 UTC (permalink / raw)
To: Vince Weaver; +Cc: P J P, Linux Kernel Mailing List
On Tue, Aug 20, 2013 at 03:42:56PM +0100, Vince Weaver wrote:
> On Tue, 20 Aug 2013, Catalin Marinas wrote:
>
> > On 20 August 2013 11:03, P J P <ppandit@redhat.com> wrote:
> > > -> https://lkml.org/lkml/2013/8/7/259
> > >
> > > I wanted to confirm if this above fix should also go into ARM64 build Or is
> > > ARM64 platform not vulnerable?
> >
> > It is and I'll push patches to mainline (Will is preparing them).
>
> You'll probably also want the equivalent of
> d9f966357b14e356dbd83b8f4a197a287ab4ff83
> as well since arch/arm64/kernel/perf_event.c
> has the same overflow in armpmu_map_event that is fixed in the mentioned
> commit.
Yes, I'm pushing both.
Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-20 16:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-20 10:03 About perf,arm -- oops in validate_event P J P
2013-08-20 10:39 ` Catalin Marinas
2013-08-20 14:42 ` Vince Weaver
2013-08-20 16:15 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.