All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>,
	david.vrabel@citrix.com, boris.ostrovsky@oracle.com
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH RFC] xenbus_client: extend interface to suppurt multi-page ring
Date: Tue, 20 Aug 2013 13:11:58 -0400	[thread overview]
Message-ID: <20130820171158.GE11652@phenom.dumpdata.com> (raw)
In-Reply-To: <20130530140912.GI4394@zion.uk.xensource.com>

On Thu, May 30, 2013 at 03:09:12PM +0100, Wei Liu wrote:
> On Thu, May 30, 2013 at 03:06:00PM +0100, Wei Liu wrote:
> > Originally Xen PV drivers only use single-page ring to pass along
> > information. This might limit the throughput between frontend and
> > backend as they can easily run out of ring slots if hardware is fast.
> > 
> > The patch extends Xenbus driver to support multi-page ring, which in
> > general should improve throughput. Changes to various frontend / backend
> > to adapt to the new interface are also included.
> > 
> > Affected Xen drivers:
> > * blkfront/back
> > * netfront/back
> > * pcifront/back
> > 
> > The interface is documented, as before, in xenbus_client.c.
> > 
> 
> Please note that this patch won't apply cleanly on upstream kernel as it
> relies on some patches that are not in tree.

OK.
> 
> I mainly want to collect views on the interface.  Also in the HVM case I
> use vmap, I would like to know if I get it right.

This patches looks familiar that I had seen some time ago (maybe I even
backported it for PV?). Anyhow the PV part looks OK.

The HVM - I don't see why we cannot do vmap. The nature of the ring is that
it stays mapped for a very long time - so using vmap is OK. That is, the
issues with vmap is that it takes a bit to setup and teardown - and that
is OK with us.

If you would like to rebase it on top of v3.11-rc5 and repost it I don't
see why we can't have it for v3.12. David, Boris?

> 
> 
> Thanks
> Wei.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
> 

  reply	other threads:[~2013-08-20 17:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 14:06 [PATCH RFC] xenbus_client: extend interface to suppurt multi-page ring Wei Liu
2013-05-30 14:09 ` Wei Liu
2013-08-20 17:11   ` Konrad Rzeszutek Wilk [this message]
2013-08-20 17:41     ` Wei Liu
2013-08-20 20:07       ` Konrad Rzeszutek Wilk
2013-08-21  3:37         ` Wei Liu
2013-08-21 11:00           ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130820171158.GE11652@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.