diff for duplicates of <20130820192228.GE12037@phenom.dumpdata.com> diff --git a/a/1.txt b/N1/1.txt index 6eee028..b90dcf2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -231,8 +231,8 @@ On Tue, Aug 13, 2013 at 06:19:35PM +0900, Inki Dae wrote: > + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > + Inki Dae -> + <inki dot dae at samsung dot com> -> + <daeinki at gmail dot com> +> + <inki dot dae@samsung dot com> +> + <daeinki@gmail dot com> > + > +This document is a guide for device-driver writers describing the DMA buffer > +synchronization API. This document also describes how to use the API to @@ -721,7 +721,7 @@ Why the (u32) casting? Don't you want %p ? > + continue; > + } > + -> + if (sobj = res_sobj) { +> + if (sobj == res_sobj) { > + res_sobj = NULL; > + mutex_unlock(&sobj->robj->lock); > + continue; @@ -733,7 +733,7 @@ Why the (u32) casting? Don't you want %p ? > + if (ret < 0) { > + contended_sobj = sobj; > + -> + if (ret = -EDEADLK) +> + if (ret == -EDEADLK) > + printk(KERN_WARNING"%s: deadlock = 0x%x\n", > + sync->name, (u32)sobj->dmabuf); @@ -793,7 +793,7 @@ do this up to five times or so and then give up? > + mutex_unlock(&res_sobj->robj->lock); > + } > + -> + if (ret = -EDEADLK) { +> + if (ret == -EDEADLK) { > + ww_mutex_lock_slow(&contended_sobj->robj->sync_lock, ctx); > + res_sobj = contended_sobj; > + @@ -852,7 +852,7 @@ do this up to five times or so and then give up? > + */ > +bool is_dmabuf_sync_supported(void) > +{ -> + return dmabuf_sync_enabled = 1; +> + return dmabuf_sync_enabled == 1; > +} > +EXPORT_SYMBOL(is_dmabuf_sync_supported); @@ -965,7 +965,7 @@ enum for 'type'? > + if (!IS_VALID_DMA_BUF_ACCESS_TYPE(type)) > + return -EINVAL; > + -> + if ((type & DMA_BUF_ACCESS_RW) = DMA_BUF_ACCESS_RW) +> + if ((type & DMA_BUF_ACCESS_RW) == DMA_BUF_ACCESS_RW) > + type &= ~DMA_BUF_ACCESS_R; Ah, that is why you are not using an enum. @@ -1363,12 +1363,12 @@ by dmabuf_sync_single_unlock" > +#define DMA_BUF_ACCESS_DMA_R (DMA_BUF_ACCESS_R | DMA_BUF_ACCESS_DMA) > +#define DMA_BUF_ACCESS_DMA_W (DMA_BUF_ACCESS_W | DMA_BUF_ACCESS_DMA) > +#define DMA_BUF_ACCESS_DMA_RW (DMA_BUF_ACCESS_DMA_R | DMA_BUF_ACCESS_DMA_W) -> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t) (t = DMA_BUF_ACCESS_R || \ -> + t = DMA_BUF_ACCESS_W || \ -> + t = DMA_BUF_ACCESS_DMA_R || \ -> + t = DMA_BUF_ACCESS_DMA_W || \ -> + t = DMA_BUF_ACCESS_RW || \ -> + t = DMA_BUF_ACCESS_DMA_RW) +> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t) (t == DMA_BUF_ACCESS_R || \ +> + t == DMA_BUF_ACCESS_W || \ +> + t == DMA_BUF_ACCESS_DMA_R || \ +> + t == DMA_BUF_ACCESS_DMA_W || \ +> + t == DMA_BUF_ACCESS_RW || \ +> + t == DMA_BUF_ACCESS_DMA_RW) > + > /** > * get_dma_buf - convenience wrapper for get_file. @@ -1588,5 +1588,5 @@ Perhaps a #define for the size? > > _______________________________________________ > dri-devel mailing list -> dri-devel@lists.freedesktop.org +> dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N1/content_digest index 64ec2aa..a9d4525 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,16 +1,9 @@ "ref\01376385576-9039-1-git-send-email-inki.dae@samsung.com\0" "ref\01376385576-9039-2-git-send-email-inki.dae@samsung.com\0" - "From\0Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>\0" - "Subject\0Re: [PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework\0" - "Date\0Tue, 20 Aug 2013 19:22:28 +0000\0" - "To\0Inki Dae <inki.dae@samsung.com>\0" - "Cc\0linux-fbdev@vger.kernel.org" - linaro-kernel@lists.linaro.org - dri-devel@lists.freedesktop.org - kyungmin.park@samsung.com - myungjoo.ham@samsung.com - linux-arm-kernel@lists.infradead.org - " linux-media@vger.kernel.org\0" + "From\0konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)\0" + "Subject\0[PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework\0" + "Date\0Tue, 20 Aug 2013 15:22:28 -0400\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Tue, Aug 13, 2013 at 06:19:35PM +0900, Inki Dae wrote:\n" @@ -246,8 +239,8 @@ "> + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" "> +\n" "> + Inki Dae\n" - "> + <inki dot dae at samsung dot com>\n" - "> + <daeinki at gmail dot com>\n" + "> + <inki dot dae@samsung dot com>\n" + "> + <daeinki@gmail dot com>\n" "> +\n" "> +This document is a guide for device-driver writers describing the DMA buffer\n" "> +synchronization API. This document also describes how to use the API to\n" @@ -736,7 +729,7 @@ "> +\t\t\tcontinue;\n" "> +\t\t}\n" "> +\n" - "> +\t\tif (sobj = res_sobj) {\n" + "> +\t\tif (sobj == res_sobj) {\n" "> +\t\t\tres_sobj = NULL;\n" "> +\t\t\tmutex_unlock(&sobj->robj->lock);\n" "> +\t\t\tcontinue;\n" @@ -748,7 +741,7 @@ "> +\t\tif (ret < 0) {\n" "> +\t\t\tcontended_sobj = sobj;\n" "> +\n" - "> +\t\t\tif (ret = -EDEADLK)\n" + "> +\t\t\tif (ret == -EDEADLK)\n" "> +\t\t\t\tprintk(KERN_WARNING\"%s: deadlock = 0x%x\\n\",\n" "> +\t\t\t\t\tsync->name, (u32)sobj->dmabuf);\n" "\n" @@ -808,7 +801,7 @@ "> +\t\tmutex_unlock(&res_sobj->robj->lock);\n" "> +\t}\n" "> +\n" - "> +\tif (ret = -EDEADLK) {\n" + "> +\tif (ret == -EDEADLK) {\n" "> +\t\tww_mutex_lock_slow(&contended_sobj->robj->sync_lock, ctx);\n" "> +\t\tres_sobj = contended_sobj;\n" "> +\n" @@ -867,7 +860,7 @@ "> + */\n" "> +bool is_dmabuf_sync_supported(void)\n" "> +{\n" - "> +\treturn dmabuf_sync_enabled = 1;\n" + "> +\treturn dmabuf_sync_enabled == 1;\n" "> +}\n" "> +EXPORT_SYMBOL(is_dmabuf_sync_supported);\n" "\n" @@ -980,7 +973,7 @@ "> +\tif (!IS_VALID_DMA_BUF_ACCESS_TYPE(type))\n" "> +\t\treturn -EINVAL;\n" "> +\n" - "> +\tif ((type & DMA_BUF_ACCESS_RW) = DMA_BUF_ACCESS_RW)\n" + "> +\tif ((type & DMA_BUF_ACCESS_RW) == DMA_BUF_ACCESS_RW)\n" "> +\t\ttype &= ~DMA_BUF_ACCESS_R;\n" "\n" "Ah, that is why you are not using an enum.\n" @@ -1378,12 +1371,12 @@ "> +#define DMA_BUF_ACCESS_DMA_R\t(DMA_BUF_ACCESS_R | DMA_BUF_ACCESS_DMA)\n" "> +#define DMA_BUF_ACCESS_DMA_W\t(DMA_BUF_ACCESS_W | DMA_BUF_ACCESS_DMA)\n" "> +#define DMA_BUF_ACCESS_DMA_RW\t(DMA_BUF_ACCESS_DMA_R | DMA_BUF_ACCESS_DMA_W)\n" - "> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t)\t(t = DMA_BUF_ACCESS_R || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_W || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_DMA_R || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_DMA_W || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_RW || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_DMA_RW)\n" + "> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t)\t(t == DMA_BUF_ACCESS_R || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_W || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_DMA_R || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_DMA_W || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_RW || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_DMA_RW)\n" "> +\n" "> /**\n" "> * get_dma_buf - convenience wrapper for get_file.\n" @@ -1603,7 +1596,7 @@ "> \n" "> _______________________________________________\n" "> dri-devel mailing list\n" - "> dri-devel@lists.freedesktop.org\n" + "> dri-devel at lists.freedesktop.org\n" > http://lists.freedesktop.org/mailman/listinfo/dri-devel -5db937af9d9c745b4adeb09fc0ad7d4e2dccc105425ba900fa1c72bd0e8542ad +764cb5a3ac3bc537f691c2818cf6d8bf5735093b8f830b89f6502bea1b2f49a0
diff --git a/a/1.txt b/N2/1.txt index 6eee028..2135362 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -721,7 +721,7 @@ Why the (u32) casting? Don't you want %p ? > + continue; > + } > + -> + if (sobj = res_sobj) { +> + if (sobj == res_sobj) { > + res_sobj = NULL; > + mutex_unlock(&sobj->robj->lock); > + continue; @@ -733,7 +733,7 @@ Why the (u32) casting? Don't you want %p ? > + if (ret < 0) { > + contended_sobj = sobj; > + -> + if (ret = -EDEADLK) +> + if (ret == -EDEADLK) > + printk(KERN_WARNING"%s: deadlock = 0x%x\n", > + sync->name, (u32)sobj->dmabuf); @@ -793,7 +793,7 @@ do this up to five times or so and then give up? > + mutex_unlock(&res_sobj->robj->lock); > + } > + -> + if (ret = -EDEADLK) { +> + if (ret == -EDEADLK) { > + ww_mutex_lock_slow(&contended_sobj->robj->sync_lock, ctx); > + res_sobj = contended_sobj; > + @@ -852,7 +852,7 @@ do this up to five times or so and then give up? > + */ > +bool is_dmabuf_sync_supported(void) > +{ -> + return dmabuf_sync_enabled = 1; +> + return dmabuf_sync_enabled == 1; > +} > +EXPORT_SYMBOL(is_dmabuf_sync_supported); @@ -965,7 +965,7 @@ enum for 'type'? > + if (!IS_VALID_DMA_BUF_ACCESS_TYPE(type)) > + return -EINVAL; > + -> + if ((type & DMA_BUF_ACCESS_RW) = DMA_BUF_ACCESS_RW) +> + if ((type & DMA_BUF_ACCESS_RW) == DMA_BUF_ACCESS_RW) > + type &= ~DMA_BUF_ACCESS_R; Ah, that is why you are not using an enum. @@ -1363,12 +1363,12 @@ by dmabuf_sync_single_unlock" > +#define DMA_BUF_ACCESS_DMA_R (DMA_BUF_ACCESS_R | DMA_BUF_ACCESS_DMA) > +#define DMA_BUF_ACCESS_DMA_W (DMA_BUF_ACCESS_W | DMA_BUF_ACCESS_DMA) > +#define DMA_BUF_ACCESS_DMA_RW (DMA_BUF_ACCESS_DMA_R | DMA_BUF_ACCESS_DMA_W) -> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t) (t = DMA_BUF_ACCESS_R || \ -> + t = DMA_BUF_ACCESS_W || \ -> + t = DMA_BUF_ACCESS_DMA_R || \ -> + t = DMA_BUF_ACCESS_DMA_W || \ -> + t = DMA_BUF_ACCESS_RW || \ -> + t = DMA_BUF_ACCESS_DMA_RW) +> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t) (t == DMA_BUF_ACCESS_R || \ +> + t == DMA_BUF_ACCESS_W || \ +> + t == DMA_BUF_ACCESS_DMA_R || \ +> + t == DMA_BUF_ACCESS_DMA_W || \ +> + t == DMA_BUF_ACCESS_RW || \ +> + t == DMA_BUF_ACCESS_DMA_RW) > + > /** > * get_dma_buf - convenience wrapper for get_file. diff --git a/a/content_digest b/N2/content_digest index 64ec2aa..e5f0a3a 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\01376385576-9039-2-git-send-email-inki.dae@samsung.com\0" "From\0Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>\0" "Subject\0Re: [PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework\0" - "Date\0Tue, 20 Aug 2013 19:22:28 +0000\0" + "Date\0Tue, 20 Aug 2013 15:22:28 -0400\0" "To\0Inki Dae <inki.dae@samsung.com>\0" "Cc\0linux-fbdev@vger.kernel.org" linaro-kernel@lists.linaro.org @@ -736,7 +736,7 @@ "> +\t\t\tcontinue;\n" "> +\t\t}\n" "> +\n" - "> +\t\tif (sobj = res_sobj) {\n" + "> +\t\tif (sobj == res_sobj) {\n" "> +\t\t\tres_sobj = NULL;\n" "> +\t\t\tmutex_unlock(&sobj->robj->lock);\n" "> +\t\t\tcontinue;\n" @@ -748,7 +748,7 @@ "> +\t\tif (ret < 0) {\n" "> +\t\t\tcontended_sobj = sobj;\n" "> +\n" - "> +\t\t\tif (ret = -EDEADLK)\n" + "> +\t\t\tif (ret == -EDEADLK)\n" "> +\t\t\t\tprintk(KERN_WARNING\"%s: deadlock = 0x%x\\n\",\n" "> +\t\t\t\t\tsync->name, (u32)sobj->dmabuf);\n" "\n" @@ -808,7 +808,7 @@ "> +\t\tmutex_unlock(&res_sobj->robj->lock);\n" "> +\t}\n" "> +\n" - "> +\tif (ret = -EDEADLK) {\n" + "> +\tif (ret == -EDEADLK) {\n" "> +\t\tww_mutex_lock_slow(&contended_sobj->robj->sync_lock, ctx);\n" "> +\t\tres_sobj = contended_sobj;\n" "> +\n" @@ -867,7 +867,7 @@ "> + */\n" "> +bool is_dmabuf_sync_supported(void)\n" "> +{\n" - "> +\treturn dmabuf_sync_enabled = 1;\n" + "> +\treturn dmabuf_sync_enabled == 1;\n" "> +}\n" "> +EXPORT_SYMBOL(is_dmabuf_sync_supported);\n" "\n" @@ -980,7 +980,7 @@ "> +\tif (!IS_VALID_DMA_BUF_ACCESS_TYPE(type))\n" "> +\t\treturn -EINVAL;\n" "> +\n" - "> +\tif ((type & DMA_BUF_ACCESS_RW) = DMA_BUF_ACCESS_RW)\n" + "> +\tif ((type & DMA_BUF_ACCESS_RW) == DMA_BUF_ACCESS_RW)\n" "> +\t\ttype &= ~DMA_BUF_ACCESS_R;\n" "\n" "Ah, that is why you are not using an enum.\n" @@ -1378,12 +1378,12 @@ "> +#define DMA_BUF_ACCESS_DMA_R\t(DMA_BUF_ACCESS_R | DMA_BUF_ACCESS_DMA)\n" "> +#define DMA_BUF_ACCESS_DMA_W\t(DMA_BUF_ACCESS_W | DMA_BUF_ACCESS_DMA)\n" "> +#define DMA_BUF_ACCESS_DMA_RW\t(DMA_BUF_ACCESS_DMA_R | DMA_BUF_ACCESS_DMA_W)\n" - "> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t)\t(t = DMA_BUF_ACCESS_R || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_W || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_DMA_R || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_DMA_W || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_RW || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_DMA_RW)\n" + "> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t)\t(t == DMA_BUF_ACCESS_R || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_W || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_DMA_R || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_DMA_W || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_RW || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_DMA_RW)\n" "> +\n" "> /**\n" "> * get_dma_buf - convenience wrapper for get_file.\n" @@ -1606,4 +1606,4 @@ "> dri-devel@lists.freedesktop.org\n" > http://lists.freedesktop.org/mailman/listinfo/dri-devel -5db937af9d9c745b4adeb09fc0ad7d4e2dccc105425ba900fa1c72bd0e8542ad +7b3b159f0e4a3bfc9d840db6a1954ef8d11ebee74d07dc4789fe6bffae157e41
diff --git a/a/1.txt b/N3/1.txt index 6eee028..2135362 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -721,7 +721,7 @@ Why the (u32) casting? Don't you want %p ? > + continue; > + } > + -> + if (sobj = res_sobj) { +> + if (sobj == res_sobj) { > + res_sobj = NULL; > + mutex_unlock(&sobj->robj->lock); > + continue; @@ -733,7 +733,7 @@ Why the (u32) casting? Don't you want %p ? > + if (ret < 0) { > + contended_sobj = sobj; > + -> + if (ret = -EDEADLK) +> + if (ret == -EDEADLK) > + printk(KERN_WARNING"%s: deadlock = 0x%x\n", > + sync->name, (u32)sobj->dmabuf); @@ -793,7 +793,7 @@ do this up to five times or so and then give up? > + mutex_unlock(&res_sobj->robj->lock); > + } > + -> + if (ret = -EDEADLK) { +> + if (ret == -EDEADLK) { > + ww_mutex_lock_slow(&contended_sobj->robj->sync_lock, ctx); > + res_sobj = contended_sobj; > + @@ -852,7 +852,7 @@ do this up to five times or so and then give up? > + */ > +bool is_dmabuf_sync_supported(void) > +{ -> + return dmabuf_sync_enabled = 1; +> + return dmabuf_sync_enabled == 1; > +} > +EXPORT_SYMBOL(is_dmabuf_sync_supported); @@ -965,7 +965,7 @@ enum for 'type'? > + if (!IS_VALID_DMA_BUF_ACCESS_TYPE(type)) > + return -EINVAL; > + -> + if ((type & DMA_BUF_ACCESS_RW) = DMA_BUF_ACCESS_RW) +> + if ((type & DMA_BUF_ACCESS_RW) == DMA_BUF_ACCESS_RW) > + type &= ~DMA_BUF_ACCESS_R; Ah, that is why you are not using an enum. @@ -1363,12 +1363,12 @@ by dmabuf_sync_single_unlock" > +#define DMA_BUF_ACCESS_DMA_R (DMA_BUF_ACCESS_R | DMA_BUF_ACCESS_DMA) > +#define DMA_BUF_ACCESS_DMA_W (DMA_BUF_ACCESS_W | DMA_BUF_ACCESS_DMA) > +#define DMA_BUF_ACCESS_DMA_RW (DMA_BUF_ACCESS_DMA_R | DMA_BUF_ACCESS_DMA_W) -> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t) (t = DMA_BUF_ACCESS_R || \ -> + t = DMA_BUF_ACCESS_W || \ -> + t = DMA_BUF_ACCESS_DMA_R || \ -> + t = DMA_BUF_ACCESS_DMA_W || \ -> + t = DMA_BUF_ACCESS_RW || \ -> + t = DMA_BUF_ACCESS_DMA_RW) +> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t) (t == DMA_BUF_ACCESS_R || \ +> + t == DMA_BUF_ACCESS_W || \ +> + t == DMA_BUF_ACCESS_DMA_R || \ +> + t == DMA_BUF_ACCESS_DMA_W || \ +> + t == DMA_BUF_ACCESS_RW || \ +> + t == DMA_BUF_ACCESS_DMA_RW) > + > /** > * get_dma_buf - convenience wrapper for get_file. diff --git a/a/content_digest b/N3/content_digest index 64ec2aa..eb1e6ee 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,15 +2,15 @@ "ref\01376385576-9039-2-git-send-email-inki.dae@samsung.com\0" "From\0Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>\0" "Subject\0Re: [PATCH 1/2] [RFC PATCH v6] dmabuf-sync: Add a buffer synchronization framework\0" - "Date\0Tue, 20 Aug 2013 19:22:28 +0000\0" + "Date\0Tue, 20 Aug 2013 15:22:28 -0400\0" "To\0Inki Dae <inki.dae@samsung.com>\0" - "Cc\0linux-fbdev@vger.kernel.org" + "Cc\0dri-devel@lists.freedesktop.org" + linux-fbdev@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-media@vger.kernel.org linaro-kernel@lists.linaro.org - dri-devel@lists.freedesktop.org kyungmin.park@samsung.com - myungjoo.ham@samsung.com - linux-arm-kernel@lists.infradead.org - " linux-media@vger.kernel.org\0" + " myungjoo.ham@samsung.com\0" "\00:1\0" "b\0" "On Tue, Aug 13, 2013 at 06:19:35PM +0900, Inki Dae wrote:\n" @@ -736,7 +736,7 @@ "> +\t\t\tcontinue;\n" "> +\t\t}\n" "> +\n" - "> +\t\tif (sobj = res_sobj) {\n" + "> +\t\tif (sobj == res_sobj) {\n" "> +\t\t\tres_sobj = NULL;\n" "> +\t\t\tmutex_unlock(&sobj->robj->lock);\n" "> +\t\t\tcontinue;\n" @@ -748,7 +748,7 @@ "> +\t\tif (ret < 0) {\n" "> +\t\t\tcontended_sobj = sobj;\n" "> +\n" - "> +\t\t\tif (ret = -EDEADLK)\n" + "> +\t\t\tif (ret == -EDEADLK)\n" "> +\t\t\t\tprintk(KERN_WARNING\"%s: deadlock = 0x%x\\n\",\n" "> +\t\t\t\t\tsync->name, (u32)sobj->dmabuf);\n" "\n" @@ -808,7 +808,7 @@ "> +\t\tmutex_unlock(&res_sobj->robj->lock);\n" "> +\t}\n" "> +\n" - "> +\tif (ret = -EDEADLK) {\n" + "> +\tif (ret == -EDEADLK) {\n" "> +\t\tww_mutex_lock_slow(&contended_sobj->robj->sync_lock, ctx);\n" "> +\t\tres_sobj = contended_sobj;\n" "> +\n" @@ -867,7 +867,7 @@ "> + */\n" "> +bool is_dmabuf_sync_supported(void)\n" "> +{\n" - "> +\treturn dmabuf_sync_enabled = 1;\n" + "> +\treturn dmabuf_sync_enabled == 1;\n" "> +}\n" "> +EXPORT_SYMBOL(is_dmabuf_sync_supported);\n" "\n" @@ -980,7 +980,7 @@ "> +\tif (!IS_VALID_DMA_BUF_ACCESS_TYPE(type))\n" "> +\t\treturn -EINVAL;\n" "> +\n" - "> +\tif ((type & DMA_BUF_ACCESS_RW) = DMA_BUF_ACCESS_RW)\n" + "> +\tif ((type & DMA_BUF_ACCESS_RW) == DMA_BUF_ACCESS_RW)\n" "> +\t\ttype &= ~DMA_BUF_ACCESS_R;\n" "\n" "Ah, that is why you are not using an enum.\n" @@ -1378,12 +1378,12 @@ "> +#define DMA_BUF_ACCESS_DMA_R\t(DMA_BUF_ACCESS_R | DMA_BUF_ACCESS_DMA)\n" "> +#define DMA_BUF_ACCESS_DMA_W\t(DMA_BUF_ACCESS_W | DMA_BUF_ACCESS_DMA)\n" "> +#define DMA_BUF_ACCESS_DMA_RW\t(DMA_BUF_ACCESS_DMA_R | DMA_BUF_ACCESS_DMA_W)\n" - "> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t)\t(t = DMA_BUF_ACCESS_R || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_W || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_DMA_R || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_DMA_W || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_RW || \\\n" - "> +\t\t\t\t\t t = DMA_BUF_ACCESS_DMA_RW)\n" + "> +#define IS_VALID_DMA_BUF_ACCESS_TYPE(t)\t(t == DMA_BUF_ACCESS_R || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_W || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_DMA_R || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_DMA_W || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_RW || \\\n" + "> +\t\t\t\t\t t == DMA_BUF_ACCESS_DMA_RW)\n" "> +\n" "> /**\n" "> * get_dma_buf - convenience wrapper for get_file.\n" @@ -1606,4 +1606,4 @@ "> dri-devel@lists.freedesktop.org\n" > http://lists.freedesktop.org/mailman/listinfo/dri-devel -5db937af9d9c745b4adeb09fc0ad7d4e2dccc105425ba900fa1c72bd0e8542ad +3cee66b2cb04ded3a905f988ff42d3caa64c151e370803abaad1603d83935269
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.