From: Christoph Hellwig <hch@infradead.org>
To: Andy Grover <agrover@redhat.com>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/5] target/qla2xxx: Define NPIV ops in terms of normal ops
Date: Tue, 20 Aug 2013 23:30:08 -0700 [thread overview]
Message-ID: <20130821063008.GD25506@infradead.org> (raw)
In-Reply-To: <1377046807-15860-5-git-send-email-agrover@redhat.com>
On Tue, Aug 20, 2013 at 06:00:06PM -0700, Andy Grover wrote:
> Instead of defining a second target_core_fabric_ops struct, use the
> same one as normal (tcm_qla2xxx_ops) and then fixup the changed methods.
>
> This should make it a little easier to pick out the npiv differences, and
> also save a little space.
>
> Signed-off-by: Andy Grover <agrover@redhat.com>
Can't say I'm a huge fan of either the old or new way, I'd rather have
the methods contain both the NPIV and non-NPIV code inline. If that's
what you're preparing for I'm supportive of this, otherwise I don't
really care too much about it. Looks correct at least..
next prev parent reply other threads:[~2013-08-21 6:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 1:00 [PATCH 0/5] Macro and qla npiv cleanups Andy Grover
2013-08-21 1:00 ` [PATCH 1/5] target: Remove TF_CIT_TMPL macro Andy Grover
2013-08-21 6:27 ` Christoph Hellwig
2013-08-21 1:00 ` [PATCH 2/5] target/iscsi: Remove iscsi dereferencing macros Andy Grover
2013-08-21 6:27 ` Christoph Hellwig
2013-08-21 1:00 ` [PATCH 3/5] target/iscsi: Remove macros that contain typecasts Andy Grover
2013-08-21 6:28 ` Christoph Hellwig
2013-08-21 1:00 ` [PATCH 4/5] target/qla2xxx: Define NPIV ops in terms of normal ops Andy Grover
2013-08-21 6:30 ` Christoph Hellwig [this message]
2013-08-21 16:02 ` Andy Grover
2013-08-21 1:00 ` [PATCH 5/5] target/qla2xxx: Remove QLA_TPG_ATTRIB macro Andy Grover
2013-08-21 6:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821063008.GD25506@infradead.org \
--to=hch@infradead.org \
--cc=agrover@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.