All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: USB: Add EHCI support for MX27 and MX31 based boards
Date: Wed, 21 Aug 2013 08:39:22 +0000	[thread overview]
Message-ID: <20130821083922.GJ5240@elgon.mountain> (raw)

[ This warning is very old actually ]

Hello Daniel Mack,

This is a semi-automatic email about new static checker warnings.

The patch 7e8d5cd93fac: "USB: Add EHCI support for MX27 and MX31 
based boards" from Oct 28, 2009, leads to the following Smatch 
complaint:

drivers/usb/host/ehci-mxc.c:187 ehci_mxc_drv_remove()
	 error: we previously assumed 'pdata' could be null (see line 184)

drivers/usb/host/ehci-mxc.c
   183	
   184		if (pdata && pdata->exit)
                    ^^^^^
New check.

   185			pdata->exit(pdev);
   186	
   187		if (pdata->otg)
                    ^^^^^^^^^^
New dereference.

   188			usb_phy_shutdown(pdata->otg);
   189	

regards,
dan carpenter

             reply	other threads:[~2013-08-21  8:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  8:39 Dan Carpenter [this message]
2013-08-21  9:18 ` USB: Add EHCI support for MX27 and MX31 based boards Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130821083922.GJ5240@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.