From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: net: Add TI DaVinci EMAC driver
Date: Wed, 21 Aug 2013 08:40:24 +0000 [thread overview]
Message-ID: <20130821084024.GK5240@elgon.mountain> (raw)
Hello Anant Gole,
The patch a6286ee630f6: "net: Add TI DaVinci EMAC driver" from May
18, 2009, has the following potentially buggy code:
drivers/net/ethernet/ti/davinci_emac.c
1316 ((EMAC_DEF_ERROR_FRAME_EN) ? (EMAC_RXMBP_CEFEN_MASK) : 0x0) |
1317 ((EMAC_DEF_PROM_EN) ? (EMAC_RXMBP_CAFEN_MASK) : 0x0) |
1318 ((EMAC_DEF_PROM_CH & EMAC_RXMBP_CHMASK) << \
^^^^^^^^^^^^^^^^
This is bit 0 but it's used as a mask. It should maybe be:
EMAC_MBP_PROMISCCH(EMAC_DEF_PROM_CH) & EMAC_RXMBP_CHMASK
1319 EMAC_RXMBP_PROMCH_SHIFT) |
1320 ((EMAC_DEF_BCAST_EN) ? (EMAC_RXMBP_BROADEN_MASK) : 0x0) |
1321 ((EMAC_DEF_BCAST_CH & EMAC_RXMBP_CHMASK) << \
^^^^^^^^^^^^^^^^^
Same thing here.
1322 EMAC_RXMBP_BROADCH_SHIFT) |
1323 ((EMAC_DEF_MCAST_EN) ? (EMAC_RXMBP_MULTIEN_MASK) : 0x0) |
1324 ((EMAC_DEF_MCAST_CH & EMAC_RXMBP_CHMASK) << \
^^^^^^^^^^^^^^^^^
1325 EMAC_RXMBP_MULTICH_SHIFT));
Really, this whole section of bit masks is very hard to look at or
review.
regards,
dan carpenter
next reply other threads:[~2013-08-21 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 8:40 Dan Carpenter [this message]
2013-08-21 8:44 ` net: Add TI DaVinci EMAC driver Gole, Anant
2013-08-21 9:11 ` Mugunthan V N
2013-08-21 9:26 ` Dan Carpenter
2013-08-21 9:33 ` Mugunthan V N
2013-08-21 10:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821084024.GK5240@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.