All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] tests: ddx_intel_after_fbdev loads intel ddx after fbdev was loaded.
Date: Wed, 21 Aug 2013 11:00:53 +0200	[thread overview]
Message-ID: <20130821090053.GC26909@phenom.ffwll.local> (raw)
In-Reply-To: <1377024185-18380-1-git-send-email-rodrigo.vivi@gmail.com>

On Tue, Aug 20, 2013 at 03:43:05PM -0300, Rodrigo Vivi wrote:
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>

I'm confused what exactly this tests, since it seems to never fail ...
automated tests should have some checks for expected results.

Also I'm not sure whether we want such ddx/X tests in igt ...
-Daniel

> ---
>  tests/Makefile.am           |  1 +
>  tests/ddx_intel_after_fbdev | 73 +++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 74 insertions(+)
>  create mode 100755 tests/ddx_intel_after_fbdev
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 9e46cac..cce75ee 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -127,6 +127,7 @@ TESTS_scripts = \
>  	sysfs_l3_parity \
>  	test_rte_check \
>  	tools_test \
> +	ddx_intel_after_fbdev \
>  	ZZ_hangman \
>  	$(NULL)
>  
> diff --git a/tests/ddx_intel_after_fbdev b/tests/ddx_intel_after_fbdev
> new file mode 100755
> index 0000000..bcd2c29
> --- /dev/null
> +++ b/tests/ddx_intel_after_fbdev
> @@ -0,0 +1,73 @@
> +#!/bin/bash
> +#
> +# Testcase: Load Intel DDX after fbdev was loaded
> +#
> +
> +whoami | grep -q root || {
> +	echo "ERROR: not running as root"
> +	exit 1
> +}
> +
> +# no other X session should be running
> +find /tmp/ -name .X*lock 2>/dev/null | grep -q X && {
> +	echo "ERROR: X session already running"
> +	exit 1
> +}
> +
> +TMPDIR=$(mktemp -d /tmp/igt.XXXX) || {
> +	echo "ERROR: Failed to create temp dir"
> +	exit 1
> +}
> +
> +cat > $TMPDIR/xorg.conf.fbdev << EOF
> +Section "Device"
> +	Driver		"fbdev"
> +	Identifier 	"Device[fbdev]"
> +EndSection
> +EOF
> +
> +cat > $TMPDIR/xorg.conf.intel << EOF
> +Section "Device"
> +	Driver		"intel"
> +	Identifier 	"Device[intel]"
> +EndSection
> +EOF
> +
> +# log before fbdev
> +dmesg -c > $TMPDIR/dmesg.1.before.fbdev
> +cp /var/log/Xorg.0.log $TMPDIR/Xorg.0.log.1.before.fbdev
> +
> +# run fbdev
> +xinit -- /usr/bin/X -config $TMPDIR/xorg.conf.fbdev & 
> +sleep 5
> +if [ -f `which intel_reg_dumper` ]; then
> +`which intel_reg_dumper` > $TMPDIR/intel_reg_dumped.1.fbdev
> +fi
> +killall X
> +
> +# log after fbdev & before intel
> +dmesg -c > $TMPDIR/dmesg.2.after.fbdev.before.intel
> +cp /var/log/Xorg.0.log $TMPDIR/Xorg.0.log.2.after.fbdev.before.intel
> +
> +sleep 5
> +
> +# run intel
> +xinit -- /usr/bin/X -config $TMPDIR/xorg.conf.intel & 
> +sleep 5 
> +if [ -f `which intel_reg_dumper` ]; then
> +`which intel_reg_dumper` > $TMPDIR/intel_reg_dumped.2.intel
> +fi
> +killall X
> +
> +# log after intel
> +dmesg -c > $TMPDIR/dmesg.3.after.intel
> +cp /var/log/Xorg.0.log $TMPDIR/Xorg.0.log.3.after.intel
> +
> +cp $0 $TMPDIR/
> +
> +tar czf $TMPDIR.tar.gz $TMPDIR/*
> +if [ -f $TMPDIR.tar.gz ]; then
> +	echo $TMPDIR.tar.gz contains this script, all configs and logs generated on this tests
> +fi
> +
> +exit 0
> -- 
> 1.8.1.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2013-08-21  9:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-20 18:43 [PATCH] tests: ddx_intel_after_fbdev loads intel ddx after fbdev was loaded Rodrigo Vivi
2013-08-21  9:00 ` Daniel Vetter [this message]
2013-08-21  9:16   ` Chris Wilson
2013-08-21  9:27     ` Daniel Vetter
2013-08-21 11:55       ` Rodrigo Vivi
2013-08-21 12:03         ` Daniel Vetter
2013-08-21 12:26           ` Rodrigo Vivi
2013-08-21 18:13           ` Rodrigo Vivi
2013-08-21 21:18             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130821090053.GC26909@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.