All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Brad Spengler <spender@grsecurity.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Colin Walters <walters@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: PATCH? fix unshare(NEWPID) && vfork()
Date: Wed, 21 Aug 2013 14:24:37 +0200	[thread overview]
Message-ID: <20130821122437.GB2965@redhat.com> (raw)
In-Reply-To: <CALCETrXnf8V+CgHDwEEviBkn0bJ60_H6G6WPmZxkQF85bqj3TQ@mail.gmail.com>

On 08/20, Andy Lutomirski wrote:
>
> On Tue, Aug 20, 2013 at 12:23 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> >> but vfork(); unshare(CLONE_NEWPID) will fail?  (I
> >> admit I haven't tested it.)
> >
> > Do you mean that the child does unshare(CLONE_NEWPID) before exec?
> > It should fail with or without this patch.
> >
>
> Exactly. Shouldn't it succeed?

Ah, I am starting to understand... Sorry, I thought that you were
arguing with the patch I sent.

Yes, perhaps you are right... But this is another isssue, and needs
another change and another discussion. Afaics, we only need to change
the "clone_flags" checks in sys_unshare().

Oleg.


  reply	other threads:[~2013-08-21 12:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 17:25 PATCH? fix unshare(NEWPID) && vfork() Oleg Nesterov
2013-08-19 17:46 ` Linus Torvalds
2013-08-19 17:51   ` Oleg Nesterov
2013-08-19 18:10 ` Andy Lutomirski
2013-08-19 18:33   ` Oleg Nesterov
2013-08-19 18:40     ` Andy Lutomirski
2013-08-19 18:43       ` Oleg Nesterov
2013-08-20 17:55         ` Eric W. Biederman
2013-08-20 18:45           ` Oleg Nesterov
2013-08-20 20:52             ` Eric W. Biederman
2013-08-21 16:35               ` Oleg Nesterov
2013-08-22 16:47                 ` Oleg Nesterov
2013-08-20 17:59         ` Andy Lutomirski
2013-08-20 18:50           ` Oleg Nesterov
2013-08-20 19:00             ` Andy Lutomirski
2013-08-20 19:05               ` Oleg Nesterov
2013-08-20 19:13                 ` Andy Lutomirski
2013-08-20 19:23                   ` Oleg Nesterov
2013-08-20 19:38                     ` Andy Lutomirski
2013-08-21 12:24                       ` Oleg Nesterov [this message]
2013-08-20 20:25               ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130821122437.GB2965@redhat.com \
    --to=oleg@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=spender@grsecurity.net \
    --cc=torvalds@linux-foundation.org \
    --cc=walters@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.