From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: comedi: pcl812: missing break statement
Date: Wed, 21 Aug 2013 12:49:24 +0000 [thread overview]
Message-ID: <20130821124924.GA4713@mwanda> (raw)
In-Reply-To: <20130821082804.GC5240@elgon.mountain>
On Wed, Aug 21, 2013 at 12:35:22PM +0100, Ian Abbott wrote:
>
> Acked-by: Ian Abbott <abbotti@mev.co.uk>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
> (whichever is appropriate)
To me Acked-by is more emphatic. Since you're the maintainer it's
appropriate. I normally use "Reviewed-by" because I don't have the
authority to approve anything. Also if it's a bug fix that I
approve of or if I previously complained about the patch then I'll
use Acked-by.
I don't know how other people do it. :P
regards,
dan carpenter
prev parent reply other threads:[~2013-08-21 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 8:28 [patch] staging: comedi: pcl812: missing break statement Dan Carpenter
2013-08-21 10:44 ` Ian Abbott
2013-08-21 11:35 ` Ian Abbott
2013-08-21 12:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821124924.GA4713@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.