From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/3] ARM: OMAP2+: Add new bindings for OMAP Date: Wed, 21 Aug 2013 05:51:47 -0700 Message-ID: <20130821125146.GJ7656@atomide.com> References: <1376983966-16490-1-git-send-email-rnayak@ti.com> <1376983966-16490-3-git-send-email-rnayak@ti.com> <20130821074514.GU7656@atomide.com> <52147E95.5000606@ti.com> <20130821085330.GH7656@atomide.com> <521486E1.6030009@ti.com> <20130821122327.GI7656@atomide.com> <5214B50D.3050703@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5214B50D.3050703@ti.com> Sender: linux-doc-owner@vger.kernel.org To: Rajendra Nayak Cc: bcousson@baylibre.com, paul@pwsan.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org List-Id: linux-omap@vger.kernel.org * Rajendra Nayak [130821 05:46]: > On Wednesday 21 August 2013 05:53 PM, Tony Lindgren wrote: > > * Rajendra Nayak [130821 02:29]: > >> On Wednesday 21 August 2013 02:23 PM, Tony Lindgren wrote: > >>> > >>> Or you could also have various bus specific bindings for the ocp > >>> with lists of phandles? > >>> > >>> ocp { > >>> reg = <...>; > >>> interrupts = <...>; > >>> ti,reset-on-init = <&module1, &module2>; > >>> ... > >>> }; > >>> > >>> Or something similar. > >> > >> The only problem I see with this is that some of these modules could be > >> board specific ones and need to be part of the board dts files, like > >> some boards which have PMIC power switch hooked up to some gpio etc. > >> So there could be some SoC specific modules (like emif/gpmc on OMAPs) > >> and some which depend on how the boards are designed. > > > > You can still override the ocp entry in the board specific .dts file. > > Would probably be a lot easier than to override each module separately > > in the board specific .dts file. > > So, If I understand this right we would have the dt entries > something like, > > omap4.dtsi > ------ > ocp { > reg = <...>; > interrupts = <...>; > ti,no-reset-on-init = <&emif1, &emif2, &gpmc>; > ... > }; > > omap4-panda-es.dts > ------ > ocp { > ti,no-reset-on-init = <&emif1, &emif2, &gpmc, &gpio4>; > ... > }; > > Is it that, or you suggesting we can _append_ the soc list of > modules with board specific modules, which I am not sure if its > possible. Yes I think the board specific entry just overrides the .dtsi entry. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 21 Aug 2013 05:51:47 -0700 Subject: [PATCH 2/3] ARM: OMAP2+: Add new bindings for OMAP In-Reply-To: <5214B50D.3050703@ti.com> References: <1376983966-16490-1-git-send-email-rnayak@ti.com> <1376983966-16490-3-git-send-email-rnayak@ti.com> <20130821074514.GU7656@atomide.com> <52147E95.5000606@ti.com> <20130821085330.GH7656@atomide.com> <521486E1.6030009@ti.com> <20130821122327.GI7656@atomide.com> <5214B50D.3050703@ti.com> Message-ID: <20130821125146.GJ7656@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Rajendra Nayak [130821 05:46]: > On Wednesday 21 August 2013 05:53 PM, Tony Lindgren wrote: > > * Rajendra Nayak [130821 02:29]: > >> On Wednesday 21 August 2013 02:23 PM, Tony Lindgren wrote: > >>> > >>> Or you could also have various bus specific bindings for the ocp > >>> with lists of phandles? > >>> > >>> ocp { > >>> reg = <...>; > >>> interrupts = <...>; > >>> ti,reset-on-init = <&module1, &module2>; > >>> ... > >>> }; > >>> > >>> Or something similar. > >> > >> The only problem I see with this is that some of these modules could be > >> board specific ones and need to be part of the board dts files, like > >> some boards which have PMIC power switch hooked up to some gpio etc. > >> So there could be some SoC specific modules (like emif/gpmc on OMAPs) > >> and some which depend on how the boards are designed. > > > > You can still override the ocp entry in the board specific .dts file. > > Would probably be a lot easier than to override each module separately > > in the board specific .dts file. > > So, If I understand this right we would have the dt entries > something like, > > omap4.dtsi > ------ > ocp { > reg = <...>; > interrupts = <...>; > ti,no-reset-on-init = <&emif1, &emif2, &gpmc>; > ... > }; > > omap4-panda-es.dts > ------ > ocp { > ti,no-reset-on-init = <&emif1, &emif2, &gpmc, &gpio4>; > ... > }; > > Is it that, or you suggesting we can _append_ the soc list of > modules with board specific modules, which I am not sure if its > possible. Yes I think the board specific entry just overrides the .dtsi entry. Regards, Tony