From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftables PATCH] src: constify nft_*_parse input data
Date: Wed, 21 Aug 2013 19:07:02 +0200 [thread overview]
Message-ID: <20130821170702.GA7947@localhost> (raw)
In-Reply-To: <20130821122127.32150.32227.stgit@nfdev.cica.es>
On Wed, Aug 21, 2013 at 02:21:28PM +0200, Arturo Borrero Gonzalez wrote:
> Since the input string is not changing, let's make it constant.
I hit these compilation warnings:
table.c: In function 'nft_table_json_parse':
table.c:278:2: warning: passing argument 1 of 'nft_jansson_create_root' discards 'const' qualifier from pointer target type [enabled by default]
In file included from table.c:11:0:
internal.h:51:9: note: expected 'char *' but argument is of type 'const char *'
chain.c: In function 'nft_chain_json_parse': CC expr.lo
rule.c: In function 'nft_rule_json_parse':
chain.c:492:2: warning: passing argument 1 of 'nft_jansson_create_root' discards 'const' qualifier from pointer target type [enabled by default]
In file included from chain.c:11:0:
internal.h:51:9: note: expected 'char *' but argument is of type 'const char *'
rule.c:489:2: warning: passing argument 1 of 'nft_jansson_create_root' discards 'const' qualifier from pointer target type [enabled by default]
In file included from rule.c:11:0:
internal.h:51:9: note: expected 'char *' but argument is of type 'const char *'
Please, fix them and resend. Thanks.
next prev parent reply other threads:[~2013-08-21 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 12:21 [libnftables PATCH] src: constify nft_*_parse input data Arturo Borrero Gonzalez
2013-08-21 17:07 ` Pablo Neira Ayuso [this message]
2013-08-21 19:21 ` Arturo Borrero Gonzalez
2013-08-22 0:19 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821170702.GA7947@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.