Re: [PATCH] sysfs: add sysfs_create/remove_groups()

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Aug 21, 2013 at 01:38:35PM -0700, Randy Dunlap wrote:
> On 08/21/13 13:35, Greg Kroah-Hartman wrote:
> > 
> > --- a/fs/sysfs/group.c
> > +++ b/fs/sysfs/group.c
> > @@ -131,6 +131,39 @@ int sysfs_create_group(struct kobject *k
> >  }
> >  
> >  /**
> > + * sysfs_create_groups - given a directory kobject, create a bunch of attribute groups
> > + * @kobj:	The kobject to create the group on
> > + * @groups:	The attribute groups to create, NULL terminated
> > + *
> > + * This function creates a bunch of attribute groups.  If an error occurs when
> > + * creating a group, all previously created groups will be removed, unwinding
> > + * everything back to the original state when this function was called.
> > + * It will explicitly warn and error if any of the attribute files being
> > + * created already exist.
> > + *
> > + * Returns 0 on success or error.
> 
> ambiguous.  How about:
>       Returns 0 on success or error code on error.

Ok, I also forgot to export these symbols, so I'll go do a v2 of the
patch, thanks for the review.

greg k-h