From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx126.postini.com [74.125.245.126]) by kanga.kvack.org (Postfix) with SMTP id 11E0C6B0032 for ; Wed, 21 Aug 2013 16:49:12 -0400 (EDT) Date: Wed, 21 Aug 2013 16:49:01 -0400 From: Dave Jones Subject: Re: unused swap offset / bad page map. Message-ID: <20130821204901.GA19802@redhat.com> References: <20130807055157.GA32278@redhat.com> <20130807153030.GA25515@redhat.com> <20130819231836.GD14369@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: Linux-MM , Linux Kernel On Tue, Aug 20, 2013 at 12:39:05PM +0800, Hillf Danton wrote: > On Tue, Aug 20, 2013 at 7:18 AM, Dave Jones wrote: > > --- a/mm/memory.c Wed Aug 7 16:29:34 2013 > +++ b/mm/memory.c Tue Aug 20 11:13:06 2013 > @@ -933,8 +933,10 @@ again: > if (progress >= 32) { > progress = 0; > if (need_resched() || > - spin_needbreak(src_ptl) || spin_needbreak(dst_ptl)) > + spin_needbreak(src_ptl) || spin_needbreak(dst_ptl)) { > + BUG_ON(entry.val); > break; > + } > } > if (pte_none(*src_pte)) { > progress++; didn't hit the bug_on, but got a bunch of [ 424.077993] swap_free: Unused swap offset entry 000187d5 [ 439.377194] swap_free: Unused swap offset entry 000187e7 [ 441.998411] swap_free: Unused swap offset entry 000187ee [ 446.956551] swap_free: Unused swap offset entry 0000245f Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899Ab3HUUtN (ORCPT ); Wed, 21 Aug 2013 16:49:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37157 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787Ab3HUUtM (ORCPT ); Wed, 21 Aug 2013 16:49:12 -0400 Date: Wed, 21 Aug 2013 16:49:01 -0400 From: Dave Jones To: Hillf Danton Cc: Linux-MM , Linux Kernel Subject: Re: unused swap offset / bad page map. Message-ID: <20130821204901.GA19802@redhat.com> Mail-Followup-To: Dave Jones , Hillf Danton , Linux-MM , Linux Kernel References: <20130807055157.GA32278@redhat.com> <20130807153030.GA25515@redhat.com> <20130819231836.GD14369@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 20, 2013 at 12:39:05PM +0800, Hillf Danton wrote: > On Tue, Aug 20, 2013 at 7:18 AM, Dave Jones wrote: > > --- a/mm/memory.c Wed Aug 7 16:29:34 2013 > +++ b/mm/memory.c Tue Aug 20 11:13:06 2013 > @@ -933,8 +933,10 @@ again: > if (progress >= 32) { > progress = 0; > if (need_resched() || > - spin_needbreak(src_ptl) || spin_needbreak(dst_ptl)) > + spin_needbreak(src_ptl) || spin_needbreak(dst_ptl)) { > + BUG_ON(entry.val); > break; > + } > } > if (pte_none(*src_pte)) { > progress++; didn't hit the bug_on, but got a bunch of [ 424.077993] swap_free: Unused swap offset entry 000187d5 [ 439.377194] swap_free: Unused swap offset entry 000187e7 [ 441.998411] swap_free: Unused swap offset entry 000187ee [ 446.956551] swap_free: Unused swap offset entry 0000245f Dave