From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
David Vrabel <david.vrabel@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Andy Lutomirski <luto@amacapital.net>,
Andrew Morton <akpm@linux-foundation.org>,
Xen-devel@lists.xen.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Pavel Emelyanov <xemul@parallels.com>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dhillf@gmail.com
Subject: Re: Regression: x86/mm: new _PTE_SWP_SOFT_DIRTY bit conflicts with existing use
Date: Wed, 21 Aug 2013 20:51:15 -0400 [thread overview]
Message-ID: <20130822005115.GA1188@redhat.com> (raw)
In-Reply-To: <CA+55aFw_tWio_ABFUocNHU+_RKe-27U9_=4ATfp3-vSWVZkdug@mail.gmail.com>
On Wed, Aug 21, 2013 at 04:04:54PM -0700, Linus Torvalds wrote:
> On Wed, Aug 21, 2013 at 12:03 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> >
> > I personally don't see bug here because
> >
> > - this swapped page soft dirty bit is set for non-present entries only,
> > never for present ones, just at moment we form swap pte entry
> >
> > - i don't find any code which would test for this bit directly without
> > is_swap_pte call
>
> Ok, having gone through the places that use swp_*soft_dirty(), I have
> to agree. Afaik, it's only ever used on a swap-entry that has (by
> definition) the P bit clear. So with or without Xen, I don't see how
> it can make any difference.
>
> David/Konrad - did you actually see any issues, or was this just from
> (mis)reading the code?
Could this explain what I'm seeing in another thread ?
https://lkml.org/lkml/2013/8/7/27
Dave
next prev parent reply other threads:[~2013-08-22 0:51 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 13:48 Regression: x86/mm: new _PTE_SWP_SOFT_DIRTY bit conflicts with existing use David Vrabel
2013-08-21 13:53 ` konrad wilk
2013-08-21 13:53 ` konrad wilk
2013-08-21 14:11 ` H. Peter Anvin
2013-08-21 14:11 ` H. Peter Anvin
2013-08-21 14:19 ` Cyrill Gorcunov
2013-08-21 14:22 ` H. Peter Anvin
2013-08-21 14:22 ` H. Peter Anvin
2013-08-21 14:29 ` Cyrill Gorcunov
2013-08-21 14:29 ` Cyrill Gorcunov
2013-08-21 16:30 ` Linus Torvalds
2013-08-21 16:42 ` Cyrill Gorcunov
2013-08-21 16:42 ` Cyrill Gorcunov
2013-08-21 23:05 ` Cyrill Gorcunov
2013-08-21 23:42 ` Andi Kleen
2013-08-21 23:42 ` Andi Kleen
2013-08-22 5:49 ` Cyrill Gorcunov
2013-08-22 5:49 ` Cyrill Gorcunov
2013-08-22 6:37 ` Minchan Kim
2013-08-22 6:37 ` Minchan Kim
2013-08-22 13:12 ` Cyrill Gorcunov
2013-08-22 13:12 ` Cyrill Gorcunov
2013-08-21 23:05 ` Cyrill Gorcunov
2013-08-27 22:04 ` Benjamin Herrenschmidt
2013-08-27 22:04 ` Benjamin Herrenschmidt
2013-08-21 16:30 ` Linus Torvalds
2013-08-21 14:19 ` Cyrill Gorcunov
2013-08-21 14:12 ` Cyrill Gorcunov
2013-08-21 14:12 ` Cyrill Gorcunov
2013-08-21 14:22 ` H. Peter Anvin
2013-08-21 14:22 ` H. Peter Anvin
2013-08-21 14:53 ` Jan Beulich
2013-08-21 14:58 ` H. Peter Anvin
2013-08-21 14:58 ` H. Peter Anvin
2013-08-21 15:42 ` Cyrill Gorcunov
2013-08-21 16:03 ` Jan Beulich
2013-08-21 16:03 ` Jan Beulich
2013-08-21 16:19 ` Cyrill Gorcunov
2013-08-21 16:19 ` Cyrill Gorcunov
2013-08-21 16:56 ` David Vrabel
2013-08-21 16:56 ` David Vrabel
2013-08-21 17:25 ` Cyrill Gorcunov
2013-08-21 18:17 ` Cyrill Gorcunov
2013-08-21 18:50 ` H. Peter Anvin
2013-08-21 19:03 ` Cyrill Gorcunov
2013-08-21 19:03 ` Cyrill Gorcunov
2013-08-21 19:07 ` Andy Lutomirski
2013-08-21 19:07 ` Andy Lutomirski
2013-08-21 19:20 ` Cyrill Gorcunov
2013-08-21 19:20 ` Cyrill Gorcunov
2013-08-21 19:21 ` Pavel Emelyanov
2013-08-21 19:21 ` Pavel Emelyanov
2013-08-21 23:04 ` Linus Torvalds
2013-08-22 0:51 ` Dave Jones
2013-08-22 0:51 ` Dave Jones [this message]
2013-08-22 5:44 ` Cyrill Gorcunov
2013-08-22 5:44 ` Cyrill Gorcunov
2013-08-22 6:41 ` Pavel Emelyanov
2013-08-22 6:41 ` Pavel Emelyanov
2013-08-22 7:47 ` Jan Beulich
2013-08-22 7:47 ` Jan Beulich
2013-08-22 9:32 ` David Vrabel
2013-08-22 9:32 ` David Vrabel
2013-08-22 10:16 ` Pavel Emelyanov
2013-08-22 10:16 ` Pavel Emelyanov
2013-08-21 23:04 ` Linus Torvalds
2013-08-21 18:50 ` H. Peter Anvin
2013-08-21 18:17 ` Cyrill Gorcunov
2013-08-21 17:25 ` Cyrill Gorcunov
2013-08-22 6:56 ` Jan Beulich
2013-08-22 7:03 ` Cyrill Gorcunov
2013-08-22 7:27 ` Jan Beulich
2013-08-22 11:27 ` Cyrill Gorcunov
2013-08-22 11:27 ` Cyrill Gorcunov
2013-08-22 11:33 ` Jan Beulich
2013-08-22 11:33 ` Jan Beulich
2013-08-22 12:18 ` Pavel Emelyanov
2013-08-22 12:18 ` Pavel Emelyanov
2013-08-22 7:27 ` Jan Beulich
2013-08-22 7:03 ` Cyrill Gorcunov
2013-08-22 6:56 ` Jan Beulich
2013-08-21 15:42 ` Cyrill Gorcunov
2013-08-21 14:53 ` Jan Beulich
2013-08-21 17:28 ` Andy Lutomirski
2013-08-22 7:54 ` Jan Beulich
2013-08-22 7:54 ` Jan Beulich
2013-08-22 9:06 ` Stefan Bader
2013-08-21 17:28 ` Andy Lutomirski
-- strict thread matches above, loose matches on Subject: below --
2013-08-21 13:48 David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822005115.GA1188@redhat.com \
--to=davej@redhat.com \
--cc=JBeulich@suse.com \
--cc=Xen-devel@lists.xen.org \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=dhillf@gmail.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.